Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2888613002: Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac This CL wires the GetPhotoCapabibilities() method for Mac and fills in the only available capability, the photo resolution, which is equal to the "live" capture resolution. This CL also fills in the Linux/CrOs capture reoslution as the only supported PhotoCapabilities.{height,width}. BUG=721478 Review-Url: https://codereview.chromium.org/2868393004 Cr-Original-Commit-Position: refs/heads/master@{#471128} Review-Url: https://codereview.chromium.org/2888613002 . Cr-Commit-Position: refs/branch-heads/3071@{#587} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cf88c011d24a48713729607f838a10fb5bd6892e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M media/capture/video/linux/v4l2_capture_delegate.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.mm View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mcasas
3 years, 7 months ago (2017-05-16 18:22:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf88c011d24a48713729607f838a10fb5bd6892e.

Powered by Google App Engine
This is Rietveld 408576698