Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac

Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac

This CL wires the GetPhotoCapabibilities() method for Mac and fills in
the only available capability, the photo resolution, which is equal to
the "live" capture resolution.

This CL also fills in the Linux/CrOs capture reoslution as the only
supported PhotoCapabilities.{height,width}.

BUG=721478
Review-Url: https://codereview.chromium.org/2868393004
Cr-Commit-Position: refs/heads/master@{#471128}
Committed: https://chromium.googlesource.com/chromium/src/+/68edd5fc2eb0f6ccdf0680870f89471f5e5ecfa4

[mcasas, 2017-05-11 19:42:48]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2017-05-11 19:42:49]

reillyg@  straightforward CL, PTAL

[Reilly Grant (use Gerrit), 2017-05-11 21:56:47]

https://codereview.chromium.org/2868393004/diff/1/media/capture/video/mac/vid...
File media/capture/video/mac/video_capture_device_mac.mm (right):

https://codereview.chromium.org/2868393004/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_mac.mm:405:
photo_capabilities->height = mojom::Range::New();
The generated code now supports passing arguments to New(). Rejoice as you can
now write:

photo_capabilities->height =
mojom::Range::New(capture_format_.frame_size.height(),
capture_format_.frame_size.height());

[mcasas, 2017-05-11 22:09:38]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2017-05-11 22:09:45]

ptal

https://codereview.chromium.org/2868393004/diff/1/media/capture/video/mac/vid...
File media/capture/video/mac/video_capture_device_mac.mm (right):

https://codereview.chromium.org/2868393004/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_mac.mm:405:
photo_capabilities->height = mojom::Range::New();
On 2017/05/11 21:56:47, Reilly Grant wrote:
> The generated code now supports passing arguments to New(). Rejoice as you can
> now write:
> 
> photo_capabilities->height =
> mojom::Range::New(capture_format_.frame_size.height(),
> capture_format_.frame_size.height());

Yay!  (4 arguments needed though, the latter 2 being
|current| and |step| [1])

[1]
https://cs.chromium.org/chromium/src/out/Debug/gen/media/capture/mojo/image_c...

[commit-bot: I haz the power, 2017-05-11 22:10:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-05-11 22:12:17]

lgtm

[mcasas, 2017-05-11 23:17:06]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-05-11 23:17:10]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-11 23:17:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:56:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494544630013540,
"parent_rev": "67cd35cee72cda91bc0f8254b1efc080e737d848", "commit_rev":
"68edd5fc2eb0f6ccdf0680870f89471f5e5ecfa4"}

[commit-bot: I haz the power, 2017-05-11 23:57:01]

Description was changed from

==========
Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac

This CL wires the GetPhotoCapabibilities() method for Mac and fills in
the only available capability, the photo resolution, which is equal to
the "live" capture resolution.

This CL also fills in the Linux/CrOs capture reoslution as the only
supported PhotoCapabilities.{height,width}.

BUG=721478
==========

to

==========
Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac

This CL wires the GetPhotoCapabibilities() method for Mac and fills in
the only available capability, the photo resolution, which is equal to
the "live" capture resolution.

This CL also fills in the Linux/CrOs capture reoslution as the only
supported PhotoCapabilities.{height,width}.

BUG=721478

Review-Url: https://codereview.chromium.org/2868393004
Cr-Commit-Position: refs/heads/master@{#471128}
Committed:
https://chromium.googlesource.com/chromium/src/+/68edd5fc2eb0f6ccdf0680870f89...
==========

[commit-bot: I haz the power, 2017-05-11 23:57:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/68edd5fc2eb0f6ccdf0680870f89...