Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)
Patch Set: one wrong conversion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
diff --git a/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc b/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
index 34ab4910ef27ffc3f1c1984be5996bab5b240004..059e4a8619b8ddecb9c8674cf6a78dd11648b8c6 100644
--- a/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
+++ b/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
@@ -43,7 +43,7 @@ void BuildColumnSet(ColumnSetType type, views::GridLayout* layout) {
const int horizontal_padding =
type == SINGLE_VIEW_COLUMN_SET
? ChromeLayoutProvider::Get()->GetDistanceMetric(
- DISTANCE_DIALOG_BUTTON_MARGIN)
+ views::DISTANCE_DIALOG_CONTENTS_HORIZONTAL_MARGIN)
: 0;
column_set->AddPaddingColumn(0, horizontal_padding);
column_set->AddColumn(views::GridLayout::FILL,
@@ -85,7 +85,7 @@ views::ScrollView* CreateCredentialsView(
credential_view->SetLowerLabelColor(kAutoSigninTextColor);
ChromeLayoutProvider* layout_provider = ChromeLayoutProvider::Get();
gfx::Insets dialog_insets =
- layout_provider->GetInsetsMetric(views::INSETS_PANEL);
+ layout_provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS);
const int vertical_padding = layout_provider->GetDistanceMetric(
views::DISTANCE_RELATED_CONTROL_VERTICAL);
credential_view->SetBorder(
@@ -220,7 +220,7 @@ void AccountChooserDialogView::InitWindow() {
// Show credentials.
gfx::Insets dialog_insets =
- layout_provider->GetInsetsMetric(views::INSETS_PANEL);
+ layout_provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS);
BuildColumnSet(SINGLE_VIEW_COLUMN_SET_NO_PADDING, layout);
layout->StartRowWithPadding(0, SINGLE_VIEW_COLUMN_SET_NO_PADDING, 0,
dialog_insets.top());

Powered by Google App Engine
This is Rietveld 408576698