chrome/browser/ui/views/page_info/page_info_bubble_view.cc - Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/page_info/page_info_bubble_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)

Patch Set: one wrong conversion Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/page_info/page_info_bubble_view.cc

diff --git a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc

index 2d10ed71e2702c2a5ffa8969ff0c9fcd3e78edf5..7fcffaece371602294bb512c37f6de0d69ea423a 100644

--- a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc

+++ b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc

@@ -487,7 +487,7 @@ PageInfoBubbleView::PageInfoBubbleView(

// horizontal insets match.

set_title_margins(

gfx::Insets(ChromeLayoutProvider::Get()->GetDistanceMetric(

- DISTANCE_PANEL_CONTENT_MARGIN),

+ views::DISTANCE_DIALOG_CONTENTS_VERTICAL_MARGIN),

side_margin, 0, side_margin));

}

views::BubbleDialogDelegateView::CreateBubble(this);