chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc - Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)

Patch Set: one wrong conversion Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

diff --git a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

index 84b96ec79e64ad083a5389992bc38fb262af31c8..39ba98c87879fe2150e19e135ce2233182441d6d 100644

--- a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

+++ b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

@@ -35,7 +35,7 @@ void BuildColumnSet(views::GridLayout* layout, ColumnSetType type) {

views::ColumnSet* column_set = layout->AddColumnSet(type);

ChromeLayoutProvider* layout_provider = ChromeLayoutProvider::Get();

gfx::Insets dialog_insets =

- layout_provider->GetInsetsMetric(views::INSETS_PANEL);

+ layout_provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS);

column_set->AddPaddingColumn(0, dialog_insets.left());

switch (type) {

case SINGLE_VIEW_COLUMN_SET:

@@ -184,7 +184,7 @@ void AutoSigninFirstRunDialogView::InitWindow() {

layout_provider->GetInsetsMetric(views::INSETS_DIALOG_TITLE).top());

layout->AddView(title_label);

const gfx::Insets dialog_insets =

- layout_provider->GetInsetsMetric(views::INSETS_PANEL);

+ layout_provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS);

layout->StartRowWithPadding(0, SINGLE_VIEW_COLUMN_SET, 0,

dialog_insets.top());

layout->AddView(content_label);

@@ -192,7 +192,7 @@ void AutoSigninFirstRunDialogView::InitWindow() {

BuildColumnSet(layout, DOUBLE_BUTTON_COLUMN_SET);

const gfx::Insets button_insets =

- layout_provider->GetInsetsMetric(views::INSETS_DIALOG_BUTTON);

+ layout_provider->GetInsetsMetric(views::INSETS_DIALOG_BUTTON_ROW);

layout->StartRowWithPadding(0, DOUBLE_BUTTON_COLUMN_SET, 0,

button_insets.top());

layout->AddView(ok_button_);