Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2888553002: Instant: small cleanups (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant: small cleanups - Remove INSTANT_SUPPORT_UNKNOWN which is now unused - Update various comments that were outdated BUG=627747 Review-Url: https://codereview.chromium.org/2888553002 Cr-Commit-Position: refs/heads/master@{#472114} Committed: https://chromium.googlesource.com/chromium/src/+/8897863a378dbe61cb411e310e2e015513a6782a

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -35 lines) Patch
M chrome/browser/ui/browser_instant_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.h View 3 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/search/instant_tab.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_model_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/search/search_types.h View 1 chunk +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
Marc Treib
PTAL!
3 years, 7 months ago (2017-05-16 15:27:11 UTC) #8
sfiera
LGTM
3 years, 7 months ago (2017-05-16 15:31:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888553002/20001
3 years, 7 months ago (2017-05-16 15:33:09 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 15:42:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8897863a378dbe61cb411e310e2e...

Powered by Google App Engine
This is Rietveld 408576698