Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2885853002: Instant: remove InstantSupportState (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant: remove InstantSupportState Nobody cares about its value or the corresponding change notifications anymore. Also remove SearchModel::State which now consisted only of the SearchMode. BUG=627747 Review-Url: https://codereview.chromium.org/2885853002 Cr-Commit-Position: refs/heads/master@{#472130} Committed: https://chromium.googlesource.com/chromium/src/+/8d6cc389014e25bb903075473ef9bba3c50faf87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -286 lines) Patch
M chrome/browser/ui/browser_instant_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 1 chunk +9 lines, -14 lines 0 comments Download
D chrome/browser/ui/search/instant_tab_unittest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/browser/ui/search/search_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_delegate.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/search/search_model.h View 2 chunks +2 lines, -36 lines 0 comments Download
M chrome/browser/ui/search/search_model.cc View 1 chunk +6 lines, -47 lines 0 comments Download
M chrome/browser/ui/search/search_model_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_model_unittest.cc View 4 chunks +21 lines, -58 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Marc Treib
Aaand an immediate followup :) PTAL again!
3 years, 7 months ago (2017-05-16 15:32:54 UTC) #5
sfiera
LGTM
3 years, 7 months ago (2017-05-16 15:50:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885853002/1
3 years, 7 months ago (2017-05-16 16:31:22 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 16:50:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d6cc389014e25bb903075473ef9...

Powered by Google App Engine
This is Rietveld 408576698