Remove references to box_data_ in ComputedStyle.

Remove references to box_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to box_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938
Review-Url: https://codereview.chromium.org/2888513002
Cr-Commit-Position: refs/heads/master@{#472238}
Committed: https://chromium.googlesource.com/chromium/src/+/9b38f0b5a429e3046188ae68e65765d57dbe018c

[shend, 2017-05-16 07:20:22]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-16 07:20:23]

Hi Naina, PTAL :)

[shend, 2017-05-16 07:20:27]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:20:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-16 07:22:51]

lgtm

[shend, 2017-05-16 07:38:07]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-05-16 07:38:07]

Hi Alan, PTAL

[alancutter (OOO until 2018), 2017-05-16 07:40:06]

lgtm

[commit-bot: I haz the power, 2017-05-16 10:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 10:48:42]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-16 22:55:45]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:57:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:06:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494975345361270, "parent_rev":
"9513fb02ee27908bacb21482a31ac3e800a135e9", "commit_rev":
"9b38f0b5a429e3046188ae68e65765d57dbe018c"}

[commit-bot: I haz the power, 2017-05-16 23:06:43]

Description was changed from

==========
Remove references to box_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to box_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938
==========

to

==========
Remove references to box_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to box_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938

Review-Url: https://codereview.chromium.org/2888513002
Cr-Commit-Position: refs/heads/master@{#472238}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b38f0b5a429e3046188ae68e657...
==========

[commit-bot: I haz the power, 2017-05-16 23:06:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b38f0b5a429e3046188ae68e657...