Remove references to visual_data_ in ComputedStyle.

Remove references to visual_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to visual_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938
Review-Url: https://codereview.chromium.org/2884833003
Cr-Commit-Position: refs/heads/master@{#472282}
Committed: https://chromium.googlesource.com/chromium/src/+/a400161f978b4d2a42c8805e9b3c7ad510ce9cb3

[shend, 2017-05-16 07:31:25]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:31:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-16 07:32:28]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-16 07:32:29]

Hi Naina, PTAL

[nainar, 2017-05-16 07:38:19]

lgtm

[shend, 2017-05-16 07:44:21]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-05-16 07:44:21]

Hi Alan, PTAL

[alancutter (OOO until 2018), 2017-05-16 07:45:37]

lgtm

[commit-bot: I haz the power, 2017-05-16 09:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 09:27:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-05-16 23:09:49]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 23:11:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:00:19]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-17 01:09:05]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:11:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:23:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494983345828420, "parent_rev":
"b498325ab6ea7c253b73d65eaf15de7c9bf073e9", "commit_rev":
"a400161f978b4d2a42c8805e9b3c7ad510ce9cb3"}

[commit-bot: I haz the power, 2017-05-17 01:23:37]

Description was changed from

==========
Remove references to visual_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to visual_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938
==========

to

==========
Remove references to visual_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to visual_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938

Review-Url: https://codereview.chromium.org/2884833003
Cr-Commit-Position: refs/heads/master@{#472282}
Committed:
https://chromium.googlesource.com/chromium/src/+/a400161f978b4d2a42c8805e9b3c...
==========

[commit-bot: I haz the power, 2017-05-17 01:23:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a400161f978b4d2a42c8805e9b3c...