Issue 2888383004: Fix FirstRunTestCase.testTermsAndConditions on official

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2888383004: Fix FirstRunTestCase.testTermsAndConditions on official (Closed)

Created:
3 years, 7 months ago by kkhorimoto

Modified:
3 years, 6 months ago

Reviewers:
gambard, kkhorimoto

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Fix FirstRunTestCase.testTermsAndConditions on official The test expected Chromium branded, which failed on Official builds. BUG=700814 R=kkhorimoto@chromium.org TBR=gambard@chromium.org Review-Url: https://codereview.chromium.org/2745123002 Cr-Original-Commit-Position: refs/heads/master@{#456437} Review-Url: https://codereview.chromium.org/2888383004 . Cr-Commit-Position: refs/branch-heads/3029@{#856} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/08a3880775332befb1c8876e0badf755ea04aac8

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ios/chrome/browser/ui/first_run/first_run_egtest.mm	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

kkhorimoto

Committed patchset #1 (id:1) manually as 08a3880775332befb1c8876e0badf755ea04aac8.

3 years, 7 months ago (2017-05-19 18:04:23 UTC) #2

Message was sent while issue was closed.

lgtm