Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2888383004: Fix FirstRunTestCase.testTermsAndConditions on official (Closed)

Created:
3 years, 7 months ago by kkhorimoto
Modified:
3 years, 6 months ago
Reviewers:
gambard, kkhorimoto
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix FirstRunTestCase.testTermsAndConditions on official The test expected Chromium branded, which failed on Official builds. BUG=700814 R=kkhorimoto@chromium.org TBR=gambard@chromium.org Review-Url: https://codereview.chromium.org/2745123002 Cr-Original-Commit-Position: refs/heads/master@{#456437} Review-Url: https://codereview.chromium.org/2888383004 . Cr-Commit-Position: refs/branch-heads/3029@{#856} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/08a3880775332befb1c8876e0badf755ea04aac8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/ui/first_run/first_run_egtest.mm View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
kkhorimoto
Committed patchset #1 (id:1) manually as 08a3880775332befb1c8876e0badf755ea04aac8.
3 years, 7 months ago (2017-05-19 18:04:23 UTC) #2
gambard
3 years, 6 months ago (2017-06-02 09:43:08 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698