Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2745123002: Fix FirstRunTestCase.testTermsAndConditions on official (Closed)

Created:
3 years, 9 months ago by lpromero
Modified:
3 years, 9 months ago
Reviewers:
gambard, kkhorimoto
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix FirstRunTestCase.testTermsAndConditions on official The test expected Chromium branded, which failed on Official builds. BUG=700814 R=kkhorimoto@chromium.org TBR=gambard@chromium.org Review-Url: https://codereview.chromium.org/2745123002 Cr-Commit-Position: refs/heads/master@{#456437} Committed: https://chromium.googlesource.com/chromium/src/+/973aa79155460a0ff6e7c36452ab18dd9c4ec960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/ui/first_run/first_run_egtest.mm View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
lpromero
3 years, 9 months ago (2017-03-13 12:43:14 UTC) #1
gambard
lgtm
3 years, 9 months ago (2017-03-13 12:58:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745123002/1
3 years, 9 months ago (2017-03-13 12:59:03 UTC) #8
kkhorimoto
lgtm
3 years, 9 months ago (2017-03-13 17:30:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745123002/1
3 years, 9 months ago (2017-03-13 18:19:05 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 18:29:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/973aa79155460a0ff6e7c36452ab...

Powered by Google App Engine
This is Rietveld 408576698