Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2888373003: Clean up unused ContentBrowserClient methods that access cookie settings.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 days, 4 hours ago by engedy
Modified:
3 days, 2 hours ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, msramek
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up unused ContentBrowserClient methods that access cookie settings. This CL deletes the following two methods in ContentBrowserClient that were used to retrieve cookie settings on behalf of features that no longer exist: ContentBrowserClient::AllowSaveLocalState ContentBrowserClient::AllowWebRTCIdentityCache See the bug for details. BUG=724442, webrtc:5708, 493212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +0 lines, -12 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 2 chunks +0 lines, -12 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 15 (11 generated)
engedy
@Henrik, @Bernhard, PTAL. @John, PTAL. Are there any special considerations for removing such methods from ...
3 days, 4 hours ago (2017-05-19 11:10:21 UTC) #6
Bernhard Bauer
LGTM, thanks for the cleanup! On 2017/05/19 11:10:21, engedy wrote: > @Henrik, @Bernhard, PTAL. > ...
3 days, 3 hours ago (2017-05-19 12:11:57 UTC) #9
engedy
> Only if they've overridden the default implementation, right? And I don't think > there ...
3 days, 3 hours ago (2017-05-19 12:14:12 UTC) #10
hbos_chromium
3 days, 2 hours ago (2017-05-19 12:37:09 UTC) #13
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06