Clean up unused ContentBrowserClient methods that access cookie settings.

Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

See the bug for details.

BUG=724442, webrtc:5708, 493212
Review-Url: https://codereview.chromium.org/2888373003
Cr-Commit-Position: refs/heads/master@{#473656}
Committed: https://chromium.googlesource.com/chromium/src/+/ee2eb64012f4a4ff273696a929450816a14a7da2

[engedy, 2017-05-19 11:01:48]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 11:02:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2017-05-19 11:03:10]

Description was changed from

==========
Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

BUG=724442
==========

to

==========
Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

BUG=724442
==========

[engedy, 2017-05-19 11:03:10]

engedy@chromium.org changed reviewers:
+ bauerb@chromium.org, hbos@chromium.org, jam@chromium.org

[engedy, 2017-05-19 11:04:14]

Description was changed from

==========
Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

BUG=724442
==========

to

==========
Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

See the bug for details.

BUG=724442,webrtc:5708,493212
==========

[engedy, 2017-05-19 11:10:21]

@Henrik, @Bernhard, PTAL.

@John, PTAL. Are there any special considerations for removing such methods from
the Content API? The methods are no longer useful and probably constitute an
implementation burden to embedders -- still, removing them will require
embedders to remove their implementation of the methods.

[commit-bot: I haz the power, 2017-05-19 12:01:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 12:01:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bernhard Bauer, 2017-05-19 12:11:57]

LGTM, thanks for the cleanup!

On 2017/05/19 11:10:21, engedy wrote:
> @Henrik, @Bernhard, PTAL.
> 
> @John, PTAL. Are there any special considerations for removing such methods
from
> the Content API? The methods are no longer useful and probably constitute an
> implementation burden to embedders -- still, removing them will require
> embedders to remove their implementation of the methods.

Only if they've overridden the default implementation, right? And I don't think
there are many embedders where that's the case for those two methods.

[engedy, 2017-05-19 12:14:12]

> Only if they've overridden the default implementation, right? And I don't
think
> there are many embedders where that's the case for those two methods.

That's correct, and that was my thinking too.

[engedy, 2017-05-19 12:14:32]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 12:14:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hbos_chromium, 2017-05-19 12:37:09]

lgtm

[commit-bot: I haz the power, 2017-05-19 13:07:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:07:08]

Dry run: This issue passed the CQ dry run.

[jam, 2017-05-22 18:13:00]

On 2017/05/19 11:10:21, engedy wrote:
> @Henrik, @Bernhard, PTAL.
> 
> @John, PTAL. Are there any special considerations for removing such methods
from
> the Content API? The methods are no longer useful and probably constitute an
> implementation burden to embedders -- still, removing them will require
> embedders to remove their implementation of the methods.

lgtm, thanks (and sorry for the delay)

no need to worry about embedders outside the chrome repo

[engedy, 2017-05-22 18:17:35]

On 2017/05/22 18:13:00, jam wrote:
> On 2017/05/19 11:10:21, engedy wrote:
> > @Henrik, @Bernhard, PTAL.
> > 
> > @John, PTAL. Are there any special considerations for removing such methods
> from
> > the Content API? The methods are no longer useful and probably constitute an
> > implementation burden to embedders -- still, removing them will require
> > embedders to remove their implementation of the methods.
> 
> lgtm, thanks (and sorry for the delay)
> 
> no need to worry about embedders outside the chrome repo

Got it. Thanks!

[engedy, 2017-05-22 18:17:47]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2017-05-22 18:18:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:30:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495477067012690, "parent_rev":
"a35bbc87b95f73f8a5a704bc178763c389f29d1a", "commit_rev":
"ee2eb64012f4a4ff273696a929450816a14a7da2"}

[commit-bot: I haz the power, 2017-05-22 19:30:26]

Description was changed from

==========
Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

See the bug for details.

BUG=724442,webrtc:5708,493212
==========

to

==========
Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

See the bug for details.

BUG=724442,webrtc:5708,493212

Review-Url: https://codereview.chromium.org/2888373003
Cr-Commit-Position: refs/heads/master@{#473656}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee2eb64012f4a4ff273696a92945...
==========

[commit-bot: I haz the power, 2017-05-22 19:30:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee2eb64012f4a4ff273696a92945...