Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2888363002: Revert of Roll clang 301384:303273. (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll clang 301384:303273. (patchset #1 id:1 of https://codereview.chromium.org/2884383004/ ) Reason for revert: Speculative revert: This might have broken cc_unittests on Linux MSan: https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests (In fact, the same tests failed on the linux_chromium_msan_rel_ng right here.) The failing tests are related to shader transpiling which uses ANGLE which uses clang. Kind of a long shot, but nothing else looks related. Original issue's description: > Roll clang 301384:303273. > > BUG=714769 > R=thakis@chromium.org > > Review-Url: https://codereview.chromium.org/2884383004 . > Cr-Commit-Position: refs/heads/master@{#472665} > Committed: https://chromium.googlesource.com/chromium/src/+/027325f153ba7f269b197cac9b43cca8519f08bf TBR=thakis@chromium.org,hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714769 Review-Url: https://codereview.chromium.org/2888363002 Cr-Commit-Position: refs/heads/master@{#472771} Committed: https://chromium.googlesource.com/chromium/src/+/d6dc38b8713ca8ac2fd49ee08f0966d221298486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Marc Treib
Created Revert of Roll clang 301384:303273.
3 years, 7 months ago (2017-05-18 11:53:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888363002/1
3 years, 7 months ago (2017-05-18 11:54:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d6dc38b8713ca8ac2fd49ee08f0966d221298486
3 years, 7 months ago (2017-05-18 11:55:39 UTC) #6
Marc Treib
3 years, 7 months ago (2017-05-18 14:13:34 UTC) #7
Message was sent while issue was closed.
On 2017/05/18 11:55:39, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/d6dc38b8713ca8ac2fd49ee08f09...

The revert seems to have helped: The first build on Linux MSan that has it
(https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/bu...)
passes cc_unittests again.

Powered by Google App Engine
This is Rietveld 408576698