Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2888323002: Generate getters/setters for border-image. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by nainar
Modified:
5 months ago
Reviewers:
meade_UTC10, shend, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate getters/setters for border-image. Currently, the border-image property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that their getters/setters can be generated as well. Diff: https://gist.github.com/dc683ef590e3d4e88e1ed7f3a54ff16f/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2888323002 Cr-Commit-Position: refs/heads/master@{#473403} Committed: https://chromium.googlesource.com/chromium/src/+/1e84b2ec2023742abc275f116a4ac54fdea6ebac

Patch Set 1 #

Total comments: 3

Patch Set 2 : Make border-image external #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Messages

Total messages: 38 (31 generated)
nainar
shend@, PTAL? Thanks!
5 months ago (2017-05-18 06:15:06 UTC) #4
shend
lgtm after comments https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h#newcode479 third_party/WebKit/Source/core/style/ComputedStyle.h:479: static NinePieceImage InitialNinePieceImage() { return NinePieceImage(); ...
5 months ago (2017-05-18 06:21:09 UTC) #7
nainar
Response. https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h#newcode479 third_party/WebKit/Source/core/style/ComputedStyle.h:479: static NinePieceImage InitialNinePieceImage() { return NinePieceImage(); } On ...
5 months ago (2017-05-18 06:26:54 UTC) #8
nainar
meade@, PTAL? Thanks! https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h#newcode479 third_party/WebKit/Source/core/style/ComputedStyle.h:479: static NinePieceImage InitialNinePieceImage() { return NinePieceImage(); ...
5 months ago (2017-05-18 06:38:49 UTC) #11
rune
rs lgtm
5 months ago (2017-05-18 11:45:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888323002/80001
5 months ago (2017-05-20 02:56:36 UTC) #35
commit-bot: I haz the power
5 months ago (2017-05-20 03:00:47 UTC) #38
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1e84b2ec2023742abc275f116a4a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa