Generate getters/setters for border-image.

Generate getters/setters for border-image.

Currently, the border-image property is a 'storage_only' field, so
it has no generated public getters/setters. This patch changes it to an
'external' field so that their getters/setters can be generated as well.

Diff: https://gist.github.com/dc683ef590e3d4e88e1ed7f3a54ff16f/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2888323002
Cr-Commit-Position: refs/heads/master@{#473403}
Committed: https://chromium.googlesource.com/chromium/src/+/1e84b2ec2023742abc275f116a4ac54fdea6ebac

[nainar, 2017-05-18 06:13:42]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 06:14:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-18 06:15:05]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-05-18 06:15:06]

shend@, 

PTAL? Thanks!

[commit-bot: I haz the power, 2017-05-18 06:20:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 06:20:13]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-05-18 06:21:09]

lgtm after comments

https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:479: static NinePieceImage
InitialNinePieceImage() { return NinePieceImage(); }
You can remove this as well :)

[nainar, 2017-05-18 06:26:54]

Response.

https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:479: static NinePieceImage
InitialNinePieceImage() { return NinePieceImage(); }
On 2017/05/18 at 06:21:08, shend wrote:
> You can remove this as well :)

No I cant - the generated function is called InitialBorderImage. 

InitialNinePieceImage is called here:
https://cs.chromium.org/chromium/src/out/Debug/gen/blink/core/StyleBuilderFun...

I can override the initial function name to be InitialNinePieceImage maybe? 

Don't want to go fiddling with generated StyleBuilderFunctions

[nainar, 2017-05-18 06:38:31]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2017-05-18 06:38:48]

nainar@chromium.org changed reviewers:
+ meade@chromium.org

[nainar, 2017-05-18 06:38:49]

meade@, 

PTAL? Thanks!

https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2888323002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:479: static NinePieceImage
InitialNinePieceImage() { return NinePieceImage(); }
Fixed by removing the custom initial value on webkit-border-image

[commit-bot: I haz the power, 2017-05-18 06:38:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 06:43:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 06:43:59]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2017-05-18 11:45:23]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-05-18 11:45:23]

rs lgtm

[nainar, 2017-05-19 00:07:09]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 00:08:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:16:40]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-19 01:55:32]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 01:57:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 02:13:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-19 02:23:47]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 02:24:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 04:26:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 04:26:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-19 15:29:48]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 15:30:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 17:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 17:19:22]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-05-20 02:56:12]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-05-20 02:56:13]

The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org,
rune@opera.com
Link to the patchset: https://codereview.chromium.org/2888323002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-20 02:56:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 03:00:35]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495248972600360,
"parent_rev": "2ae3a0a699cdb174ed7646ba10597f84bbb496ff", "commit_rev":
"1e84b2ec2023742abc275f116a4ac54fdea6ebac"}

[commit-bot: I haz the power, 2017-05-20 03:00:45]

Description was changed from

==========
Generate getters/setters for border-image.

Currently, the border-image property is a 'storage_only' field, so
it has no generated public getters/setters. This patch changes it to an
'external' field so that their getters/setters can be generated as well.

Diff: https://gist.github.com/dc683ef590e3d4e88e1ed7f3a54ff16f/revisions

BUG=628043
==========

to

==========
Generate getters/setters for border-image.

Currently, the border-image property is a 'storage_only' field, so
it has no generated public getters/setters. This patch changes it to an
'external' field so that their getters/setters can be generated as well.

Diff: https://gist.github.com/dc683ef590e3d4e88e1ed7f3a54ff16f/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2888323002
Cr-Commit-Position: refs/heads/master@{#473403}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e84b2ec2023742abc275f116a4a...
==========

[commit-bot: I haz the power, 2017-05-20 03:00:47]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1e84b2ec2023742abc275f116a4a...