chrome/browser/extensions/api/notifications/extension_notification_handler.h - Issue 2888303004: Minimize the delegate dependencies for non persistent notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.h

Issue 2888303004: Minimize the delegate dependencies for non persistent notifications. (Closed)

Patch Set: review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/notifications/extension_notification_handler.h

diff --git a/chrome/browser/extensions/api/notifications/extension_notification_handler.h b/chrome/browser/extensions/api/notifications/extension_notification_handler.h

index 5e888624c2c48cd8e4f62414dec3f52dd38f9ac8..f4fa8e91db57d7d0cd2e5021481674d003f2f182 100644

--- a/chrome/browser/extensions/api/notifications/extension_notification_handler.h

+++ b/chrome/browser/extensions/api/notifications/extension_notification_handler.h

@@ -31,8 +31,6 @@ class ExtensionNotificationHandler : public NotificationHandler {

int action_index,

const base::NullableString16& reply) override;

void OpenSettings(Profile* profile) override;

- void RegisterNotification(const std::string& notification_id,

- NotificationDelegate* delegate) override;

protected:

// Overriden in unit tests.

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/extensions/api/notifications/extension_notification_handler.cc » ('j') | no next file with comments »