Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.h

Issue 2888303004: Minimize the delegate dependencies for non persistent notifications. (Closed)
Patch Set: review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDL ER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDL ER_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDL ER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDL ER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/notifications/notification_handler.h" 9 #include "chrome/browser/notifications/notification_handler.h"
10 #include "extensions/browser/event_router.h" 10 #include "extensions/browser/event_router.h"
(...skipping 13 matching lines...) Expand all
24 void OnClose(Profile* profile, 24 void OnClose(Profile* profile,
25 const std::string& origin, 25 const std::string& origin,
26 const std::string& notification_id, 26 const std::string& notification_id,
27 bool by_user) override; 27 bool by_user) override;
28 void OnClick(Profile* profile, 28 void OnClick(Profile* profile,
29 const std::string& origin, 29 const std::string& origin,
30 const std::string& notification_id, 30 const std::string& notification_id,
31 int action_index, 31 int action_index,
32 const base::NullableString16& reply) override; 32 const base::NullableString16& reply) override;
33 void OpenSettings(Profile* profile) override; 33 void OpenSettings(Profile* profile) override;
34 void RegisterNotification(const std::string& notification_id,
35 NotificationDelegate* delegate) override;
36 34
37 protected: 35 protected:
38 // Overriden in unit tests. 36 // Overriden in unit tests.
39 virtual void SendEvent(Profile* profile, 37 virtual void SendEvent(Profile* profile,
40 const std::string& extension_id, 38 const std::string& extension_id,
41 events::HistogramValue histogram_value, 39 events::HistogramValue histogram_value,
42 const std::string& name, 40 const std::string& name,
43 EventRouter::UserGestureState user_gesture, 41 EventRouter::UserGestureState user_gesture,
44 std::unique_ptr<base::ListValue> args); 42 std::unique_ptr<base::ListValue> args);
45 43
46 DISALLOW_COPY_AND_ASSIGN(ExtensionNotificationHandler); 44 DISALLOW_COPY_AND_ASSIGN(ExtensionNotificationHandler);
47 }; 45 };
48 46
49 } // namespace extensions 47 } // namespace extensions
50 48
51 #endif // CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HA NDLER_H_ 49 #endif // CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HA NDLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/extensions/api/notifications/extension_notification_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698