chrome/browser/extensions/api/notifications/extension_notification_handler.cc - Issue 2888303004: Minimize the delegate dependencies for non persistent notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.cc

Issue 2888303004: Minimize the delegate dependencies for non persistent notifications. (Closed)

Patch Set: review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/extension_notification_handler.h ('k') | chrome/browser/extensions/api/notifications/notifications_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/extension_notification_handler.cc

diff --git a/chrome/browser/extensions/api/notifications/extension_notification_handler.cc b/chrome/browser/extensions/api/notifications/extension_notification_handler.cc

index 38bd2c70d956274a14e8f31af6ef3747c813fa89..5167f4cf40bfb6aeb86f13853d81ed1ed4c6b33c 100644

--- a/chrome/browser/extensions/api/notifications/extension_notification_handler.cc

+++ b/chrome/browser/extensions/api/notifications/extension_notification_handler.cc

@@ -96,10 +96,6 @@ void ExtensionNotificationHandler::OpenSettings(Profile* profile) {

NOTREACHED();

}

-void ExtensionNotificationHandler::RegisterNotification(

- const std::string& notification_id,

- NotificationDelegate* delegate) {}

void ExtensionNotificationHandler::SendEvent(

Profile* profile,

const std::string& extension_id,