Revert of Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.

Revert of Introduce WebPluginContainerBase to abstract WebPluginContainerImpl. (patchset #2 id:20001 of https://codereview.chromium.org/2886113002/ )

Reason for revert:
Causes leak failure in editing/selection/selection-plugin-clear-crash.html.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4790

(and locally, I get crashes in debug)

Original issue's description:
> Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.
> 
> Many classes in web/ take a dependancy on WebPluginContainerImpl, in some cases
> this dependency is cyclic. In order to break this dependency we introduce a new
> temporary abstraction WebPluginContainerBase, that derives from PlugingView,
> WebPluginContainer and ContextClient.
> 
> Classes that were taking a dependency on WebPluginContainerImpl now take a
> dependency on WebPluginContainerBase. In cases where there we methods that
> were only defined in WebPluginContainerImpl we make them pure virtual in
> WebPluginContainerBase and override them in WebPluginContainerImpl.
> 
> As WebPluginContainerImpl is garbage collected, we move this to
> WebPluginContainerBase and define a virtual trace method.
> 
> The intention is for this abstraction to be temporary, once we move all of the
> dependencies into core/ we can remove it.
> 
> I put the new class in core/exported as it derives from WebPluginContainer.
> 
> 
> BUG=712963
> 
> Review-Url: https://codereview.chromium.org/2886113002
> Cr-Commit-Position: refs/heads/master@{#472810}
> Committed: https://chromium.googlesource.com/chromium/src/+/303acce5cc18d95d46342bd089e06957841bc21b

TBR=tkent@chromium.org,dcheng@chromium.org,sashab@chromium.org,slangley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=712963
Review-Url: https://codereview.chromium.org/2888283004
Cr-Commit-Position: refs/heads/master@{#472915}
Committed: https://chromium.googlesource.com/chromium/src/+/ba5159d871bb21b4b151262dd9234d0261b81331

[jbroman, 2017-05-18 20:19:49]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-05-18 20:19:50]

Created Revert of Introduce WebPluginContainerBase to abstract
WebPluginContainerImpl.

[commit-bot: I haz the power, 2017-05-18 20:21:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 20:22:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495138789869710, "parent_rev":
"6d7a0de064043e4322a39cab31cd99b2a5972d71", "commit_rev":
"ba5159d871bb21b4b151262dd9234d0261b81331"}

[commit-bot: I haz the power, 2017-05-18 20:22:47]

Description was changed from

==========
Revert of Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.
(patchset #2 id:20001 of https://codereview.chromium.org/2886113002/ )

Reason for revert:
Causes leak failure in editing/selection/selection-plugin-clear-crash.html.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

(and locally, I get crashes in debug)

Original issue's description:
> Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.
> 
> Many classes in web/ take a dependancy on WebPluginContainerImpl, in some
cases
> this dependency is cyclic. In order to break this dependency we introduce a
new
> temporary abstraction WebPluginContainerBase, that derives from PlugingView,
> WebPluginContainer and ContextClient.
> 
> Classes that were taking a dependency on WebPluginContainerImpl now take a
> dependency on WebPluginContainerBase. In cases where there we methods that
> were only defined in WebPluginContainerImpl we make them pure virtual in
> WebPluginContainerBase and override them in WebPluginContainerImpl.
> 
> As WebPluginContainerImpl is garbage collected, we move this to
> WebPluginContainerBase and define a virtual trace method.
> 
> The intention is for this abstraction to be temporary, once we move all of the
> dependencies into core/ we can remove it.
> 
> I put the new class in core/exported as it derives from WebPluginContainer.
> 
> 
> BUG=712963
> 
> Review-Url: https://codereview.chromium.org/2886113002
> Cr-Commit-Position: refs/heads/master@{#472810}
> Committed:
https://chromium.googlesource.com/chromium/src/+/303acce5cc18d95d46342bd089e0...

TBR=tkent@chromium.org,dcheng@chromium.org,sashab@chromium.org,slangley@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=712963
==========

to

==========
Revert of Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.
(patchset #2 id:20001 of https://codereview.chromium.org/2886113002/ )

Reason for revert:
Causes leak failure in editing/selection/selection-plugin-clear-crash.html.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

(and locally, I get crashes in debug)

Original issue's description:
> Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.
> 
> Many classes in web/ take a dependancy on WebPluginContainerImpl, in some
cases
> this dependency is cyclic. In order to break this dependency we introduce a
new
> temporary abstraction WebPluginContainerBase, that derives from PlugingView,
> WebPluginContainer and ContextClient.
> 
> Classes that were taking a dependency on WebPluginContainerImpl now take a
> dependency on WebPluginContainerBase. In cases where there we methods that
> were only defined in WebPluginContainerImpl we make them pure virtual in
> WebPluginContainerBase and override them in WebPluginContainerImpl.
> 
> As WebPluginContainerImpl is garbage collected, we move this to
> WebPluginContainerBase and define a virtual trace method.
> 
> The intention is for this abstraction to be temporary, once we move all of the
> dependencies into core/ we can remove it.
> 
> I put the new class in core/exported as it derives from WebPluginContainer.
> 
> 
> BUG=712963
> 
> Review-Url: https://codereview.chromium.org/2886113002
> Cr-Commit-Position: refs/heads/master@{#472810}
> Committed:
https://chromium.googlesource.com/chromium/src/+/303acce5cc18d95d46342bd089e0...

TBR=tkent@chromium.org,dcheng@chromium.org,sashab@chromium.org,slangley@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=712963

Review-Url: https://codereview.chromium.org/2888283004
Cr-Commit-Position: refs/heads/master@{#472915}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba5159d871bb21b4b151262dd923...
==========

[commit-bot: I haz the power, 2017-05-18 20:22:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba5159d871bb21b4b151262dd923...

[tkent, 2017-05-18 23:24:17]

lgtm