third_party/WebKit/Source/web/WebPluginContainerImpl.cpp - Issue 2888283004: Revert of Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 2888283004: Revert of Introduce WebPluginContainerBase to abstract WebPluginContainerImpl. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

index be8f613bc2f617b7964e92263928cc6760e35540..6cbf14726ace79d4fe6c51272924af9033fe9ea4 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

@@ -665,7 +665,7 @@

WebPluginContainerImpl::WebPluginContainerImpl(HTMLPlugInElement* element,

WebPlugin* web_plugin)

- : WebPluginContainerBase(element->GetDocument().GetFrame()),

+ : ContextClient(element->GetDocument().GetFrame()),

element_(element),

web_plugin_(web_plugin),

web_layer_(nullptr),

@@ -701,7 +701,8 @@

DEFINE_TRACE(WebPluginContainerImpl) {

visitor->Trace(parent_);

visitor->Trace(element_);

- WebPluginContainerBase::Trace(visitor);

+ ContextClient::Trace(visitor);

+ PluginView::Trace(visitor);

}

void WebPluginContainerImpl::HandleMouseEvent(MouseEvent* event) {