third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js - Issue 2888263002: DevTools: Roll Lighthouse binary to 2.0.1-alpha.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js

Issue 2888263002: DevTools: Roll Lighthouse binary to 2.0.1-alpha.0 (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js ('k') | third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js b/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js

index 3d054a4ed142dc18e4336ab27f32a7f08f92118f..1ea401d3a995bff8c9858fbd7238866dfef81536 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js

@@ -15,7 +15,7 @@

'use strict';

-/* globals self CriticalRequestChainRenderer */

+/* globals self CriticalRequestChainRenderer Util */

class DetailsRenderer {

/**

@@ -218,7 +218,7 @@ class DetailsRenderer {

let timing = thumbnail.timing.toLocaleString() + ' ms';

if (thumbnail.timing > 1000) {

- timing = Math.round(thumbnail.timing / 100) / 10 + ' s';

+ timing = Util.formatNumber(thumbnail.timing / 1000) + ' s';

}

const timingEl = this._dom.createChildOf(frameEl, 'div', 'lh-filmstrip__timestamp');

@@ -326,6 +326,7 @@ DetailsRenderer.ThumbnailDetails; // eslint-disable-line no-unused-expressions

/** @typedef {{

* type: string,

+ * scale: number,

* items: !Array<{timing: number, timestamp: number, data: string}>,

* }}