Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2888233002: Make disabling accelerated VPX decoding a GPU driver bug workaround. (Closed)

Created:
3 years, 7 months ago by jbauman
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, rjkroege, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Make disabling accelerated VPX decoding a GPU driver bug workaround. This is currently a blacklist entry, which means that it's calculated in the browser and the resulting decision could be incorrect if the GPU process uses a different GPU from what the browser expects. If this is a GPU driver bug workaround entry then it'll be determined with more information in the GPU process. TBR=zmo@chromium.org BUG=687004, 712006 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2682723003 Cr-Original-Commit-Position: refs/heads/master@{#469513} Review-Url: https://codereview.chromium.org/2888233002 . Cr-Commit-Position: refs/branch-heads/3071@{#623} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0fa9cda3c18d314dab4b971123f26cb5b9480344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -96 lines) Patch
M content/browser/gpu/compositor_util.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_testing_arrays_and_structs_autogen.h View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/config/gpu_blacklist.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_blacklist_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.json View 1 chunk +53 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_feature_type.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/software_rendering_list.json View 2 chunks +0 lines, -53 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_test_common.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M media/gpu/gpu_video_decode_accelerator_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/gpu_video_decode_accelerator_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/ui/gpu/gpu_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/gpu/gpu_service.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
jbauman
3 years, 7 months ago (2017-05-18 23:50:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fa9cda3c18d314dab4b971123f26cb5b9480344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698