Make disabling accelerated VPX decoding a GPU driver bug workaround.

Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2682723003
Cr-Commit-Position: refs/heads/master@{#469513}
Committed: https://chromium.googlesource.com/chromium/src/+/beabb626561e9899cb3099b3c7cd5a1447bf00f7

[jbauman, 2017-02-07 23:57:46]

Description was changed from

==========
Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
==========

to

==========
Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-02-07 23:57:52]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 23:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:13:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbauman, 2017-02-08 00:32:59]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 00:34:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-02-08 01:06:57]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 01:07:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 03:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 03:45:53]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-02-10 23:25:48]

jbauman@chromium.org changed reviewers:
+ sadrul@chromium.org, zmo@chromium.org

[sadrul, 2017-02-11 18:48:47]

lgtm

[Zhenyao Mo, 2017-02-13 22:14:27]

https://codereview.chromium.org/2682723003/diff/40001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_workaround_type.h (right):

https://codereview.chromium.org/2682723003/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_workaround_type.h:210:
GPU_OP(DISABLE_ACCELERATED_VPX_DECODE,                     \
alphabetical order

https://codereview.chromium.org/2682723003/diff/40001/services/ui/gpu/gpu_mai...
File services/ui/gpu/gpu_main.cc (right):

https://codereview.chromium.org/2682723003/diff/40001/services/ui/gpu/gpu_mai...
services/ui/gpu/gpu_main.cc:223: gpu::GpuDriverBugWorkarounds workarounds(
We actually recomputed workarounds on GPU process startup.  You should use that
instead.

See gpu_init.cc.

Not sure how you wire that to here though.

[jbauman, 2017-02-14 01:32:57]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 01:33:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:37:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:37:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jbauman, 2017-04-25 22:06:08]

Description was changed from

==========
Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-04-25 22:06:13]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 22:07:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:20:14]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jbauman, 2017-04-25 22:30:15]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 22:31:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:33:29]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-04-26 21:04:40]

PTAL

On 2017/02/13 22:14:27, Zhenyao Mo wrote:
>
https://codereview.chromium.org/2682723003/diff/40001/gpu/config/gpu_driver_b...
> File gpu/config/gpu_driver_bug_workaround_type.h (right):
> 
>
https://codereview.chromium.org/2682723003/diff/40001/gpu/config/gpu_driver_b...
> gpu/config/gpu_driver_bug_workaround_type.h:210:
> GPU_OP(DISABLE_ACCELERATED_VPX_DECODE,                     \
> alphabetical order
> 
Done.

>
https://codereview.chromium.org/2682723003/diff/40001/services/ui/gpu/gpu_mai...
> File services/ui/gpu/gpu_main.cc (right):
> 
>
https://codereview.chromium.org/2682723003/diff/40001/services/ui/gpu/gpu_mai...
> services/ui/gpu/gpu_main.cc:223: gpu::GpuDriverBugWorkarounds workarounds(
> We actually recomputed workarounds on GPU process startup.  You should use
that
> instead.
> 
> See gpu_init.cc.
> 
> Not sure how you wire that to here though.

That recomputes everything, but instead of generating the
GpuDriverBugWorkarounds it just modifies the command-line. So I think it makes
sense to grab the workarounds later off of the command line when they're
actually needed first.

[Zhenyao Mo, 2017-05-04 17:16:32]

On 2017/04/26 21:04:40, jbauman wrote:
> PTAL
> 
> On 2017/02/13 22:14:27, Zhenyao Mo wrote:
> >
>
https://codereview.chromium.org/2682723003/diff/40001/gpu/config/gpu_driver_b...
> > File gpu/config/gpu_driver_bug_workaround_type.h (right):
> > 
> >
>
https://codereview.chromium.org/2682723003/diff/40001/gpu/config/gpu_driver_b...
> > gpu/config/gpu_driver_bug_workaround_type.h:210:
> > GPU_OP(DISABLE_ACCELERATED_VPX_DECODE,                     \
> > alphabetical order
> > 
> Done.
> 
> >
>
https://codereview.chromium.org/2682723003/diff/40001/services/ui/gpu/gpu_mai...
> > File services/ui/gpu/gpu_main.cc (right):
> > 
> >
>
https://codereview.chromium.org/2682723003/diff/40001/services/ui/gpu/gpu_mai...
> > services/ui/gpu/gpu_main.cc:223: gpu::GpuDriverBugWorkarounds workarounds(
> > We actually recomputed workarounds on GPU process startup.  You should use
> that
> > instead.
> > 
> > See gpu_init.cc.
> > 
> > Not sure how you wire that to here though.
> 
> That recomputes everything, but instead of generating the
> GpuDriverBugWorkarounds it just modifies the command-line. So I think it makes
> sense to grab the workarounds later off of the command line when they're
> actually needed first.

I didn't realize it simply appended the command-line switch.

LGTM

[jbauman, 2017-05-04 20:54:28]

jbauman@chromium.org changed reviewers:
+ sandersd@chromium.org

[jbauman, 2017-05-04 20:54:28]

sandersd@: media/gpu OWNERS review.

[sandersd (OOO until July 31), 2017-05-04 21:07:01]

media/ lgtm.

[jbauman, 2017-05-04 21:07:33]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-05-04 21:07:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2682723003/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-04 21:08:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 23:23:00]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493932053094770,
"parent_rev": "2c0a34fb259f6d8381a4c6ddce21bc8850c6a806", "commit_rev":
"beabb626561e9899cb3099b3c7cd5a1447bf00f7"}

[commit-bot: I haz the power, 2017-05-04 23:24:06]

Description was changed from

==========
Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2682723003
Cr-Commit-Position: refs/heads/master@{#469513}
Committed:
https://chromium.googlesource.com/chromium/src/+/beabb626561e9899cb3099b3c7cd...
==========

[commit-bot: I haz the power, 2017-05-04 23:24:07]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/beabb626561e9899cb3099b3c7cd...