Add separate feature flag for VR CCT browsing.

Add separate feature flag for VR CCT browsing.

We need separate launch review for CCT browsing, independent of the VR browser for CTA, so create a separate feature for it.

BUG=719659
Review-Url: https://codereview.chromium.org/2888203003
Cr-Commit-Position: refs/heads/master@{#473019}
Committed: https://chromium.googlesource.com/chromium/src/+/700b0b6c899ea08aaf497df10a5cae70a59ec3b6

[mthiesse, 2017-05-17 22:43:52]

mthiesse@chromium.org changed reviewers:
+ amp@chromium.org, ymalik@chromium.org

[mthiesse, 2017-05-17 22:43:52]

PTAL

[amp, 2017-05-17 23:22:04]

lgtm

https://codereview.chromium.org/2888203003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2888203003/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2017:
FEATURE_VALUE_TYPE(chrome::android::kVrCustomTabBrowsing)},
The namespace threw me off for a bit here, but I guess it's only ever going to
be applicable for Android.

It does make me wonder if we should move the vr shell flag out of the ANDROID if
def, but I guess it wouldn't do anything yet anyway (but then again the
experimental rendering flag doesn't do anything on non-Android either).

[mthiesse, 2017-05-17 23:49:47]

The CQ bit was checked by mthiesse@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:51:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 01:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:23:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[ymalik, 2017-05-18 13:55:28]

lgtm

[mthiesse, 2017-05-18 14:49:37]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-05-18 14:49:38]

The patchset sent to the CQ was uploaded after l-g-t-m from ymalik@chromium.org,
amp@chromium.org
Link to the patchset: https://codereview.chromium.org/2888203003/#ps20001
(title: "Add histogram enums + add matching buildflags for descriptions.")

[commit-bot: I haz the power, 2017-05-18 14:50:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 15:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 15:53:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mthiesse, 2017-05-18 18:04:26]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:05:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 23:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 23:35:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mthiesse, 2017-05-18 23:42:20]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-05-18 23:44:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 01:37:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495150940982650,
"parent_rev": "c5ff6b33a647af9bcd5b2966fe94b912b215787b", "commit_rev":
"700b0b6c899ea08aaf497df10a5cae70a59ec3b6"}

[commit-bot: I haz the power, 2017-05-19 01:37:45]

Description was changed from

==========
Add separate feature flag for VR CCT browsing.

We need separate launch review for CCT browsing, independent of the VR browser
for CTA, so create a separate feature for it.

BUG=719659
==========

to

==========
Add separate feature flag for VR CCT browsing.

We need separate launch review for CCT browsing, independent of the VR browser
for CTA, so create a separate feature for it.

BUG=719659

Review-Url: https://codereview.chromium.org/2888203003
Cr-Commit-Position: refs/heads/master@{#473019}
Committed:
https://chromium.googlesource.com/chromium/src/+/700b0b6c899ea08aaf497df10a5c...
==========

[commit-bot: I haz the power, 2017-05-19 01:37:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/700b0b6c899ea08aaf497df10a5c...