Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/flag_descriptions.h

Issue 2888203003: Add separate feature flag for VR CCT browsing. (Closed)
Patch Set: Add histogram enums + add matching buildflags for descriptions. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/chrome_feature_list.cc ('k') | chrome/browser/flag_descriptions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FLAG_DESCRIPTIONS_H_ 5 #ifndef CHROME_BROWSER_FLAG_DESCRIPTIONS_H_
6 #define CHROME_BROWSER_FLAG_DESCRIPTIONS_H_ 6 #define CHROME_BROWSER_FLAG_DESCRIPTIONS_H_
7 7
8 // Includes needed for macros allowing conditional compilation of some strings. 8 // Includes needed for macros allowing conditional compilation of some strings.
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "build/buildflag.h" 10 #include "build/buildflag.h"
11 #include "device/vr/features/features.h"
11 #include "media/media_features.h" 12 #include "media/media_features.h"
12 13
13 // This file declares strings used in chrome://flags. These messages are not 14 // This file declares strings used in chrome://flags. These messages are not
14 // translated, because instead of end-users they target Chromium developers and 15 // translated, because instead of end-users they target Chromium developers and
15 // testers. See https://crbug.com/587272 and https://crbug.com/703134 for more 16 // testers. See https://crbug.com/587272 and https://crbug.com/703134 for more
16 // details. 17 // details.
17 // 18 //
18 // Comments are not necessary. The contents of the strings (which appear in the 19 // Comments are not necessary. The contents of the strings (which appear in the
19 // UI) should be good enough documentation for what flags do and when they 20 // UI) should be good enough documentation for what flags do and when they
20 // apply. If they aren't, fix them. 21 // apply. If they aren't, fix them.
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
775 776
776 extern const char kWebrtcHwVP8EncodingName[]; 777 extern const char kWebrtcHwVP8EncodingName[];
777 extern const char kWebrtcHwVP8EncodingDescription[]; 778 extern const char kWebrtcHwVP8EncodingDescription[];
778 779
779 extern const char kWebrtcSrtpAesGcmName[]; 780 extern const char kWebrtcSrtpAesGcmName[];
780 extern const char kWebrtcSrtpAesGcmDescription[]; 781 extern const char kWebrtcSrtpAesGcmDescription[];
781 782
782 extern const char kWebrtcStunOriginName[]; 783 extern const char kWebrtcStunOriginName[];
783 extern const char kWebrtcStunOriginDescription[]; 784 extern const char kWebrtcStunOriginDescription[];
784 785
786 #if BUILDFLAG(ENABLE_VR)
785 extern const char kWebvrExperimentalRenderingName[]; 787 extern const char kWebvrExperimentalRenderingName[];
786 extern const char kWebvrExperimentalRenderingDescription[]; 788 extern const char kWebvrExperimentalRenderingDescription[];
789 #endif // ENABLE_VR
787 790
788 extern const char kWebvrName[]; 791 extern const char kWebvrName[];
789 extern const char kWebvrDescription[]; 792 extern const char kWebvrDescription[];
790 793
791 extern const char kWifiCredentialSyncName[]; 794 extern const char kWifiCredentialSyncName[];
792 extern const char kWifiCredentialSyncDescription[]; 795 extern const char kWifiCredentialSyncDescription[];
793 796
794 extern const char kZeroCopyName[]; 797 extern const char kZeroCopyName[];
795 extern const char kZeroCopyDescription[]; 798 extern const char kZeroCopyDescription[];
796 799
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
926 929
927 extern const char kEnableOfflinePreviewsName[]; 930 extern const char kEnableOfflinePreviewsName[];
928 extern const char kEnableOfflinePreviewsDescription[]; 931 extern const char kEnableOfflinePreviewsDescription[];
929 932
930 extern const char kEnableOskOverscrollName[]; 933 extern const char kEnableOskOverscrollName[];
931 extern const char kEnableOskOverscrollDescription[]; 934 extern const char kEnableOskOverscrollDescription[];
932 935
933 extern const char kEnableSpecialLocaleName[]; 936 extern const char kEnableSpecialLocaleName[];
934 extern const char kEnableSpecialLocaleDescription[]; 937 extern const char kEnableSpecialLocaleDescription[];
935 938
939 #if BUILDFLAG(ENABLE_VR)
940
936 extern const char kEnableVrShellName[]; 941 extern const char kEnableVrShellName[];
937 extern const char kEnableVrShellDescription[]; 942 extern const char kEnableVrShellDescription[];
938 943
944 extern const char kVrCustomTabBrowsingName[];
945 extern const char kVrCustomTabBrowsingDescription[];
946
947 #endif // BUILDFLAG(ENABLE_VR)
948
939 extern const char kEnableWebapk[]; 949 extern const char kEnableWebapk[];
940 extern const char kEnableWebapkDescription[]; 950 extern const char kEnableWebapkDescription[];
941 951
942 extern const char kEnableWebNfcName[]; 952 extern const char kEnableWebNfcName[];
943 extern const char kEnableWebNfcDescription[]; 953 extern const char kEnableWebNfcDescription[];
944 954
945 extern const char kEnableWebPaymentsSingleAppUiSkipName[]; 955 extern const char kEnableWebPaymentsSingleAppUiSkipName[];
946 extern const char kEnableWebPaymentsSingleAppUiSkipDescription[]; 956 extern const char kEnableWebPaymentsSingleAppUiSkipDescription[];
947 957
948 extern const char kHerbPrototypeChoicesName[]; 958 extern const char kHerbPrototypeChoicesName[];
(...skipping 504 matching lines...) Expand 10 before | Expand all | Expand 10 after
1453 #endif // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID) 1463 #endif // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
1454 1464
1455 // ============================================================================ 1465 // ============================================================================
1456 // Don't just add flags to the end, put them in the right section in 1466 // Don't just add flags to the end, put them in the right section in
1457 // alphabetical order. See top instructions for more. 1467 // alphabetical order. See top instructions for more.
1458 // ============================================================================ 1468 // ============================================================================
1459 1469
1460 } // namespace flag_descriptions 1470 } // namespace flag_descriptions
1461 1471
1462 #endif // CHROME_BROWSER_FLAG_DESCRIPTIONS_H_ 1472 #endif // CHROME_BROWSER_FLAG_DESCRIPTIONS_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/chrome_feature_list.cc ('k') | chrome/browser/flag_descriptions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698