Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3429)

Unified Diff: chrome/test/chromedriver/devtools_events_logger.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/devtools_events_logger.cc
diff --git a/chrome/test/chromedriver/devtools_events_logger.cc b/chrome/test/chromedriver/devtools_events_logger.cc
index 668bd7a5fdbc49b1c9fb3e19361821199f08b9cb..e11bc9c21d1f84745870b66488adf6f73c564033 100644
--- a/chrome/test/chromedriver/devtools_events_logger.cc
+++ b/chrome/test/chromedriver/devtools_events_logger.cc
@@ -5,6 +5,8 @@
#include "chrome/test/chromedriver/devtools_events_logger.h"
#include "base/json/json_writer.h"
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
#include "chrome/test/chromedriver/chrome/devtools_client.h"
#include "chrome/test/chromedriver/chrome/devtools_client_impl.h"
@@ -33,7 +35,7 @@ Status DevToolsEventsLogger::OnEvent(DevToolsClient* client,
if (it != events_.end()) {
base::DictionaryValue log_message_dict;
log_message_dict.SetString("method", method);
- log_message_dict.Set("params", params.DeepCopy());
+ log_message_dict.Set("params", base::MakeUnique<base::Value>(params));
std::string log_message_json;
base::JSONWriter::Write(log_message_dict, &log_message_json);

Powered by Google App Engine
This is Rietveld 408576698