Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/prerender/prerender_history.h ('K') | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/devtools_events_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index 86ba264b57fa15a9342afffd4213e454fa851ba9..5c5af31e771b477443d25a6e37755cbcae9a95e0 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -73,8 +73,8 @@ void ExecuteStubGetSession(int* count,
std::unique_ptr<base::DictionaryValue> capabilities(
new base::DictionaryValue());
- capabilities->Set("capability1", new base::Value("test1"));
- capabilities->Set("capability2", new base::Value("test2"));
+ capabilities->SetString("capability1", "test1");
+ capabilities->SetString("capability2", "test2");
callback.Run(Status(kOk), std::move(capabilities), session_id, false);
}
« chrome/browser/prerender/prerender_history.h ('K') | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/devtools_events_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698