chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc - Issue 2888073002: Remove raw DictionaryValue::Set in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)

Patch Set: Fix Tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_management_unittest.cc ('k') | chrome/browser/media_galleries/media_galleries_test_util.cc » ('j') | chrome/browser/prerender/prerender_history.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

index e3a8405a3ca0b964a3130cc71e0ecb4e5cfb05a7..5417eca617468ddf7ae1103ff630586c926a149b 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

@@ -65,7 +65,7 @@ bool ChromeWebViewGuestDelegate::HandleContextMenu(

std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());

std::unique_ptr<base::ListValue> items =

MenuModelToValue(pending_menu_->menu_model());

- args->Set(webview::kContextMenuItems, items.release());

+ args->Set(webview::kContextMenuItems, std::move(items));

args->SetInteger(webview::kRequestId, request_id);

web_view_guest()->DispatchEventToView(base::MakeUnique<GuestViewEvent>(

webview::kEventContextMenuShow, std::move(args)));