Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2129)

Unified Diff: chrome/browser/extensions/extension_management_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_unittest.cc
diff --git a/chrome/browser/extensions/extension_management_unittest.cc b/chrome/browser/extensions/extension_management_unittest.cc
index cc192efa2056f6c353726e582305006cc4a7c7c2..761a03ad5b08fcb1e5fe6de912c92d9c96a90857 100644
--- a/chrome/browser/extensions/extension_management_unittest.cc
+++ b/chrome/browser/extensions/extension_management_unittest.cc
@@ -10,6 +10,7 @@
#include <vector>
#include "base/json/json_parser.h"
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_management_internal.h"
#include "chrome/browser/extensions/extension_management_test_util.h"
@@ -265,7 +266,8 @@ class ExtensionAdminPolicyTest : public ExtensionManagementServiceTest {
void CreateHostedApp(Manifest::Location location) {
base::DictionaryValue values;
- values.Set(extensions::manifest_keys::kWebURLs, new base::ListValue());
+ values.Set(extensions::manifest_keys::kWebURLs,
+ base::MakeUnique<base::ListValue>());
values.SetString(extensions::manifest_keys::kLaunchWebURL,
"http://www.example.com");
CreateExtensionFromValues(location, &values);

Powered by Google App Engine
This is Rietveld 408576698