Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5901)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_event_router.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.cc b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
index bc76ad20066f8ae42db841fb7948f054e197d0a6..b9968c7e56edcc57932c268b9f446f2008cd8af6 100644
--- a/chrome/browser/extensions/api/tabs/tabs_event_router.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
@@ -55,7 +55,7 @@ bool WillDispatchTabUpdatedEvent(
const base::Value* value = nullptr;
for (const auto& property : changed_property_names) {
if (tab_value->Get(property, &value))
- changed_properties->Set(property, value->CreateDeepCopy());
+ changed_properties->Set(property, base::MakeUnique<base::Value>(*value));
}
event->event_args->Set(1, std::move(changed_properties));
@@ -354,7 +354,7 @@ void TabsEventRouter::TabSelectionChanged(
base::MakeUnique<Value>(
ExtensionTabUtil::GetWindowIdOfTabStripModel(tab_strip_model)));
- select_info->Set(tabs_constants::kTabIdsKey, all_tabs.release());
+ select_info->Set(tabs_constants::kTabIdsKey, std::move(all_tabs));
args->Append(std::move(select_info));
// The onHighlighted event replaced onHighlightChanged.

Powered by Google App Engine
This is Rietveld 408576698