Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2881613002: Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder. (Closed)

Created:
3 years, 7 months ago by mmenke
Modified:
3 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder. This adds URLRequestContextBuilderV8, which can construct a URLRequestContext using either type of ProxyResolver. When using such a resolver, the ProxyService will fetch requests using the URLRequestContext that was created with the builder. Added a subclass instead of modifying URLRequestContextBuilder so it can continue to be used without depending on V8. BUG=717253 Review-Url: https://codereview.chromium.org/2881613002 Cr-Commit-Position: refs/heads/master@{#472439} Committed: https://chromium.googlesource.com/chromium/src/+/f4fc1f04fe1a0d835a508720fdd90841a8d1583b

Patch Set 1 #

Patch Set 2 : Fix Android? #

Patch Set 3 : Fix non-Android #

Patch Set 4 : Oops #

Patch Set 5 : Add comments, polish a bit #

Patch Set 6 : Forgot to remove WaitForConnectionsListener #

Total comments: 4

Patch Set 7 : Merge #

Total comments: 16

Patch Set 8 : Response to comments #

Patch Set 9 : Missed one, fix comment #

Patch Set 10 : Missed some ENABLE_MOJOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+586 lines, -89 lines) Patch
M net/BUILD.gn View 1 2 3 4 5 6 7 8 chunks +44 lines, -3 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 2 3 4 5 4 chunks +5 lines, -33 lines 0 comments Download
M net/proxy/proxy_service_mojo_unittest.cc View 4 chunks +2 lines, -32 lines 0 comments Download
A net/proxy/test_mojo_proxy_resolver_factory.h View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A net/proxy/test_mojo_proxy_resolver_factory.cc View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
M net/test/embedded_test_server/http_request.cc View 1 chunk +1 line, -1 line 0 comments Download
A net/test/embedded_test_server/simple_connection_listener.h View 1 2 3 4 5 6 7 1 chunk +67 lines, -0 lines 0 comments Download
A net/test/embedded_test_server/simple_connection_listener.cc View 1 2 3 4 5 6 7 1 chunk +41 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 2 3 4 5 6 7 8 3 chunks +17 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 4 5 6 7 4 chunks +40 lines, -19 lines 0 comments Download
A net/url_request/url_request_context_builder_v8.h View 1 2 3 4 5 6 7 8 9 1 chunk +92 lines, -0 lines 0 comments Download
A net/url_request/url_request_context_builder_v8.cc View 1 2 3 4 5 6 7 8 9 1 chunk +64 lines, -0 lines 0 comments Download
A net/url_request/url_request_context_builder_v8_unittest.cc View 1 2 3 4 5 6 7 1 chunk +127 lines, -0 lines 0 comments Download

Messages

Total messages: 58 (50 generated)
mmenke
[eroman]: PTAL. This CL is pretty good sized, but I'm hoping it won't be too ...
3 years, 7 months ago (2017-05-12 17:19:41 UTC) #29
mmenke
[eroman]: Just want to make sure this one's on your radar.
3 years, 7 months ago (2017-05-16 19:46:11 UTC) #37
eroman
I had started this but didn't finish. Looking now.
3 years, 7 months ago (2017-05-16 19:55:16 UTC) #38
eroman
lgtm https://codereview.chromium.org/2881613002/diff/200001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/2881613002/diff/200001/net/BUILD.gn#newcode2706 net/BUILD.gn:2706: defines += [ "ENABLE_MOJO" ] This define is ...
3 years, 7 months ago (2017-05-16 20:21:21 UTC) #39
mmenke
https://codereview.chromium.org/2881613002/diff/200001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/2881613002/diff/200001/net/BUILD.gn#newcode2706 net/BUILD.gn:2706: defines += [ "ENABLE_MOJO" ] On 2017/05/16 20:21:20, eroman ...
3 years, 7 months ago (2017-05-17 02:29:59 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881613002/280001
3 years, 7 months ago (2017-05-17 13:25:41 UTC) #54
commit-bot: I haz the power
Committed patchset #10 (id:280001) as https://chromium.googlesource.com/chromium/src/+/f4fc1f04fe1a0d835a508720fdd90841a8d1583b
3 years, 7 months ago (2017-05-17 13:30:47 UTC) #57
pasko
3 years, 7 months ago (2017-05-19 12:41:00 UTC) #58
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:280001) has been created in
https://codereview.chromium.org/2888043008/ by pasko@chromium.org.

The reason for reverting is: http://crbug.com/724471 
V8InProcessShutdownWithHungRequest flaky on a cronet bot.

Powered by Google App Engine
This is Rietveld 408576698