Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2888043006: ServiceWorker: Refactor CrossSiteTransfer on ServiceWorkerProviderHost (Closed)

Created:
3 years, 7 months ago by shimazu
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Refactor CrossSiteTransfer on ServiceWorkerProviderHost This patch is changing names of varibables and the argument of CompleteCrossSiteTransfer to clarify provider host which is created in PrepareForCrossSiteTransfer is temporally used. This patch split off from https://crrev.com/2653493009. BUG=N/A Review-Url: https://codereview.chromium.org/2888043006 Cr-Commit-Position: refs/heads/master@{#473123} Committed: https://chromium.googlesource.com/chromium/src/+/d9f77a30d1fec84cb5dd1d7c225f089d9b735412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -28 lines) Patch
M content/browser/service_worker/service_worker_context_core.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
shimazu
ptal, thanks!
3 years, 7 months ago (2017-05-18 10:32:10 UTC) #5
falken
lgtm
3 years, 7 months ago (2017-05-19 06:39:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888043006/1
3 years, 7 months ago (2017-05-19 06:50:10 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 07:56:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9f77a30d1fec84cb5dd1d7c225f...

Powered by Google App Engine
This is Rietveld 408576698