Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2888043006: ServiceWorker: Refactor CrossSiteTransfer on ServiceWorkerProviderHost (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 8bf299bc7bb2ad5ad83a3cd51d7dc6272313eba2..407b6dcb25bb0ca5fb8459d6bd83476fa3e6eb7d 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -681,9 +681,9 @@ ServiceWorkerContextCore::TransferProviderHostOut(int process_id,
int provider_id) {
ProviderMap* map = GetProviderMapForProcess(process_id);
ServiceWorkerProviderHost* transferee = map->Lookup(provider_id);
- std::unique_ptr<ServiceWorkerProviderHost> replacement =
+ std::unique_ptr<ServiceWorkerProviderHost> provisional_host =
transferee->PrepareForCrossSiteTransfer();
- return map->Replace(provider_id, std::move(replacement));
+ return map->Replace(provider_id, std::move(provisional_host));
}
void ServiceWorkerContextCore::TransferProviderHostIn(
@@ -691,16 +691,12 @@ void ServiceWorkerContextCore::TransferProviderHostIn(
int new_provider_id,
std::unique_ptr<ServiceWorkerProviderHost> transferee) {
ProviderMap* map = GetProviderMapForProcess(new_process_id);
- ServiceWorkerProviderHost* temp = map->Lookup(new_provider_id);
- if (!temp)
+ ServiceWorkerProviderHost* provisional_host = map->Lookup(new_provider_id);
+ if (!provisional_host)
return;
- DCHECK(temp->document_url().is_empty());
- transferee->CompleteCrossSiteTransfer(new_process_id,
- temp->frame_id(),
- new_provider_id,
- temp->provider_type(),
- temp->dispatcher_host());
+ DCHECK(provisional_host->document_url().is_empty());
+ transferee->CompleteCrossSiteTransfer(provisional_host);
map->Replace(new_provider_id, std::move(transferee));
}
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698