Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: cc/surfaces/direct_compositor_frame_sink.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/direct_compositor_frame_sink.cc
diff --git a/cc/surfaces/direct_compositor_frame_sink.cc b/cc/surfaces/direct_compositor_frame_sink.cc
index 505d38ad0914acc436e7641685d1489688b9f16d..c128843fcb87fcfc86011e41bfb9d2f3e56c29e4 100644
--- a/cc/surfaces/direct_compositor_frame_sink.cc
+++ b/cc/surfaces/direct_compositor_frame_sink.cc
@@ -110,6 +110,13 @@ void DirectCompositorFrameSink::SubmitCompositorFrame(CompositorFrame frame) {
std::move(frame));
}
+void DirectCompositorFrameSink::BeginFrameDidNotProduceFrame(
+ const BeginFrameAck& ack) {
+ DCHECK(!ack.has_damage);
+ DCHECK_LE(BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
+ support_->BeginFrameDidNotProduceFrame(ack);
+}
+
void DirectCompositorFrameSink::DisplayOutputSurfaceLost() {
is_lost_ = true;
client_->DidLoseCompositorFrameSink();
@@ -152,10 +159,6 @@ void DirectCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frame) {
support_->SetNeedsBeginFrame(needs_begin_frame);
}
-void DirectCompositorFrameSink::OnDidFinishFrame(const BeginFrameAck& ack) {
- // If there was damage, SubmitCompositorFrame includes the ack.
- if (!ack.has_damage)
- support_->BeginFrameDidNotSwap(ack);
-}
+void DirectCompositorFrameSink::OnDidFinishFrame(const BeginFrameAck& ack) {}
piman 2017/05/18 19:16:37 nit: Are there any non-empty OnDidFinishFrame left
Eric Seckler 2017/05/19 08:13:37 You're right, done. Also got rid of the related ob
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698