cc/ipc/mojo_compositor_frame_sink.mojom - Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/ipc/mojo_compositor_frame_sink.mojom

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/ipc/mojo_compositor_frame_sink.mojom

diff --git a/cc/ipc/mojo_compositor_frame_sink.mojom b/cc/ipc/mojo_compositor_frame_sink.mojom

index 7bb993226520f0504b1a44766988e6eeb18cd322..104f44ca4e1e20b5adec3ce1ae4aa626eef3b851 100644

--- a/cc/ipc/mojo_compositor_frame_sink.mojom

+++ b/cc/ipc/mojo_compositor_frame_sink.mojom

@@ -37,7 +37,7 @@ interface MojoCompositorFrameSink {

// Notifies the frame sink that a BeginFrame was completed, but that no

// CompositorFrame was produced as a result of it.

- BeginFrameDidNotSwap(cc.mojom.BeginFrameAck ack);

+ BeginFrameDidNotProduceFrame(cc.mojom.BeginFrameAck ack);

sunnyps 2017/05/22 07:17:12 nit: My suggestion was DidNotProduceFrame (skippin

Eric Seckler 2017/05/22 11:29:58 Ah, misunderstood. Renamed, I like it shorter, too

// Notify that the surface is no longer in use (and is okay to be evicted) so

// that its resources gets returned in time.