[cc] Add and plumb CFS::DidNotProduceFrame.

cc/surfaces/direct_compositor_frame_sink.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/direct_compositor_frame_sink.h"
 
 #include "base/bind.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/compositor_frame_sink_client.h"
 #include "cc/surfaces/display.h"
@@ skipping 92 matching lines @@
     delegated_local_surface_id_ = local_surface_id_allocator_.GenerateId();
     last_swap_frame_size_ = frame_size;
   }
   display_->SetLocalSurfaceId(delegated_local_surface_id_,
                               frame.metadata.device_scale_factor);
 
   support_->SubmitCompositorFrame(delegated_local_surface_id_,
                                   std::move(frame));
 }
 
+void DirectCompositorFrameSink::BeginFrameDidNotProduceFrame(
+    const BeginFrameAck& ack) {
+  DCHECK(!ack.has_damage);
+  DCHECK_LE(BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
+  support_->BeginFrameDidNotProduceFrame(ack);
+}
+
 void DirectCompositorFrameSink::DisplayOutputSurfaceLost() {
   is_lost_ = true;
   client_->DidLoseCompositorFrameSink();
 }
 
 void DirectCompositorFrameSink::DisplayWillDrawAndSwap(
     bool will_draw_and_swap,
     const RenderPassList& render_passes) {
   // This notification is not relevant to our client outside of tests.
 }
@@ skipping 22 matching lines @@
 void DirectCompositorFrameSink::WillDrawSurface(
     const LocalSurfaceId& local_surface_id,
     const gfx::Rect& damage_rect) {
   // TODO(staraz): Implement this.
 }
 
 void DirectCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frame) {
   support_->SetNeedsBeginFrame(needs_begin_frame);
 }
 
-void DirectCompositorFrameSink::OnDidFinishFrame(const BeginFrameAck& ack) {
-  // If there was damage, SubmitCompositorFrame includes the ack.
-  if (!ack.has_damage)
-    support_->BeginFrameDidNotSwap(ack);
-}
+void DirectCompositorFrameSink::OnDidFinishFrame(const BeginFrameAck& ack) {}

[piman, 2017/05/18 19:16:37]

nit: Are there any non-empty OnDidFinishFrame left? Could it be removed
altogether?

[Eric Seckler, 2017/05/19 08:13:37]

You're right, done. Also got rid of the related observer tracking in
ExternalBFS.

 
 }  // namespace cc