Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: cc/ipc/mojo_compositor_frame_sink.mojom

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module cc.mojom; 5 module cc.mojom;
6 6
7 import "cc/ipc/begin_frame_args.mojom"; 7 import "cc/ipc/begin_frame_args.mojom";
8 import "cc/ipc/compositor_frame.mojom"; 8 import "cc/ipc/compositor_frame.mojom";
9 import "cc/ipc/copy_output_request.mojom"; 9 import "cc/ipc/copy_output_request.mojom";
10 import "cc/ipc/frame_sink_id.mojom"; 10 import "cc/ipc/frame_sink_id.mojom";
(...skipping 19 matching lines...) Expand all
30 // surface (e.g. during resize), then it can simply allocate a new 30 // surface (e.g. during resize), then it can simply allocate a new
31 // |local_surface_id|. 31 // |local_surface_id|.
32 // For successful swaps, the implementation must call 32 // For successful swaps, the implementation must call
33 // DidReceiveCompositorFrameAck() asynchronously when the frame has been 33 // DidReceiveCompositorFrameAck() asynchronously when the frame has been
34 // processed in order to unthrottle the next frame. 34 // processed in order to unthrottle the next frame.
35 SubmitCompositorFrame(cc.mojom.LocalSurfaceId local_surface_id, 35 SubmitCompositorFrame(cc.mojom.LocalSurfaceId local_surface_id,
36 cc.mojom.CompositorFrame frame); 36 cc.mojom.CompositorFrame frame);
37 37
38 // Notifies the frame sink that a BeginFrame was completed, but that no 38 // Notifies the frame sink that a BeginFrame was completed, but that no
39 // CompositorFrame was produced as a result of it. 39 // CompositorFrame was produced as a result of it.
40 BeginFrameDidNotSwap(cc.mojom.BeginFrameAck ack); 40 BeginFrameDidNotProduceFrame(cc.mojom.BeginFrameAck ack);
sunnyps 2017/05/22 07:17:12 nit: My suggestion was DidNotProduceFrame (skippin
Eric Seckler 2017/05/22 11:29:58 Ah, misunderstood. Renamed, I like it shorter, too
41 41
42 // Notify that the surface is no longer in use (and is okay to be evicted) so 42 // Notify that the surface is no longer in use (and is okay to be evicted) so
43 // that its resources gets returned in time. 43 // that its resources gets returned in time.
44 EvictCurrentSurface(); 44 EvictCurrentSurface();
45 }; 45 };
46 46
47 interface MojoCompositorFrameSinkClient { 47 interface MojoCompositorFrameSinkClient {
48 // Notification that the previous CompositorFrame given to 48 // Notification that the previous CompositorFrame given to
49 // SubmitCompositorFrame() has been processed and that another frame 49 // SubmitCompositorFrame() has been processed and that another frame
50 // can be submitted. This provides backpressure from the display compositor 50 // can be submitted. This provides backpressure from the display compositor
(...skipping 16 matching lines...) Expand all
67 interface MojoCompositorFrameSinkPrivate { 67 interface MojoCompositorFrameSinkPrivate {
68 // Claims this FrameSinkId will embed |surface_id| so it should own the 68 // Claims this FrameSinkId will embed |surface_id| so it should own the
69 // temporary reference to |surface_id|. 69 // temporary reference to |surface_id|.
70 ClaimTemporaryReference(SurfaceId surface_id); 70 ClaimTemporaryReference(SurfaceId surface_id);
71 71
72 // Requests that the renderer send back a copy of the surface that this 72 // Requests that the renderer send back a copy of the surface that this
73 // CompositorFrameSink submits to. The result can be in form of a bitmap 73 // CompositorFrameSink submits to. The result can be in form of a bitmap
74 // or a texture. See cc::CopyOutputRequest. 74 // or a texture. See cc::CopyOutputRequest.
75 RequestCopyOfSurface(cc.mojom.CopyOutputRequest request); 75 RequestCopyOfSurface(cc.mojom.CopyOutputRequest request);
76 }; 76 };
OLDNEW
« no previous file with comments | « no previous file | cc/output/compositor_frame_sink.h » ('j') | cc/surfaces/direct_compositor_frame_sink.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698