Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: content/test/gpu/gpu_tests/webgl_conformance_integration_test.py

Issue 2887983002: Re-enable GPU watchdog for WebGL conformance tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import os 6 import os
7 import sys 7 import sys
8 8
9 from gpu_tests import gpu_integration_test 9 from gpu_tests import gpu_integration_test
10 from gpu_tests import path_util 10 from gpu_tests import path_util
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 def CustomizeOptions(cls): 252 def CustomizeOptions(cls):
253 assert cls._webgl_version == 1 or cls._webgl_version == 2 253 assert cls._webgl_version == 1 or cls._webgl_version == 2
254 browser_options = cls._finder_options.browser_options 254 browser_options = cls._finder_options.browser_options
255 # --test-type=gpu is used only to suppress the "Google API Keys are missing" 255 # --test-type=gpu is used only to suppress the "Google API Keys are missing"
256 # infobar, which causes flakiness in tests. 256 # infobar, which causes flakiness in tests.
257 browser_options.AppendExtraBrowserArgs([ 257 browser_options.AppendExtraBrowserArgs([
258 '--ignore-autoplay-restrictions', 258 '--ignore-autoplay-restrictions',
259 '--disable-domain-blocking-for-3d-apis', 259 '--disable-domain-blocking-for-3d-apis',
260 '--disable-gpu-process-crash-limit', 260 '--disable-gpu-process-crash-limit',
261 '--test-type=gpu', 261 '--test-type=gpu',
262 '--enable-experimental-canvas-features', 262 '--enable-experimental-canvas-features'
263 # Try disabling the GPU watchdog to see if this affects the 263 # If intermittent GPU process hangs are seen on the waterfall,
264 # intermittent GPU process hangs that have been seen on the 264 # try re-adding the --disable-gpu-watchdog flag here.
265 # waterfall. crbug.com/596622 crbug.com/609252 265 # crbug.com/596622 crbug.com/609252
266 '--disable-gpu-watchdog'
267 ]) 266 ])
268 267
269 builtin_js_flags = '--js-flags=--expose-gc' 268 builtin_js_flags = '--js-flags=--expose-gc'
270 found_js_flags = False 269 found_js_flags = False
271 user_js_flags = '' 270 user_js_flags = ''
272 if browser_options.extra_browser_args: 271 if browser_options.extra_browser_args:
273 for o in browser_options.extra_browser_args: 272 for o in browser_options.extra_browser_args:
274 if o.startswith('--js-flags'): 273 if o.startswith('--js-flags'):
275 found_js_flags = True 274 found_js_flags = True
276 user_js_flags = o 275 user_js_flags = o
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 if webgl_version > 1: 395 if webgl_version > 1:
397 test += '?webglVersion=' + str(webgl_version) 396 test += '?webglVersion=' + str(webgl_version)
398 test_paths.append(test) 397 test_paths.append(test)
399 398
400 return test_paths 399 return test_paths
401 400
402 401
403 def load_tests(loader, tests, pattern): 402 def load_tests(loader, tests, pattern):
404 del loader, tests, pattern # Unused. 403 del loader, tests, pattern # Unused.
405 return gpu_integration_test.LoadAllTestsInModule(sys.modules[__name__]) 404 return gpu_integration_test.LoadAllTestsInModule(sys.modules[__name__])
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698