Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 2887973002: Fix an IME regression for <webview> due to missing IPC message param (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_plugin/browser_plugin_guest.h" 5 #include "content/browser/browser_plugin/browser_plugin_guest.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 902 matching lines...) Expand 10 before | Expand all | Expand 10 after
913 void BrowserPluginGuest::OnImeCommitText( 913 void BrowserPluginGuest::OnImeCommitText(
914 int browser_plugin_instance_id, 914 int browser_plugin_instance_id,
915 const base::string16& text, 915 const base::string16& text,
916 const std::vector<blink::WebCompositionUnderline>& underlines, 916 const std::vector<blink::WebCompositionUnderline>& underlines,
917 const gfx::Range& replacement_range, 917 const gfx::Range& replacement_range,
918 int relative_cursor_pos) { 918 int relative_cursor_pos) {
919 Send(new InputMsg_ImeCommitText(routing_id(), text, underlines, 919 Send(new InputMsg_ImeCommitText(routing_id(), text, underlines,
920 replacement_range, relative_cursor_pos)); 920 replacement_range, relative_cursor_pos));
921 } 921 }
922 922
923 void BrowserPluginGuest::OnImeFinishComposingText(bool keep_selection) { 923 void BrowserPluginGuest::OnImeFinishComposingText(
924 int browser_plugin_instance_id,
925 bool keep_selection) {
926 DCHECK_EQ(browser_plugin_instance_id_, browser_plugin_instance_id);
924 Send(new InputMsg_ImeFinishComposingText(routing_id(), keep_selection)); 927 Send(new InputMsg_ImeFinishComposingText(routing_id(), keep_selection));
925 } 928 }
926 929
927 void BrowserPluginGuest::OnExtendSelectionAndDelete( 930 void BrowserPluginGuest::OnExtendSelectionAndDelete(
928 int browser_plugin_instance_id, 931 int browser_plugin_instance_id,
929 int before, 932 int before,
930 int after) { 933 int after) {
931 RenderFrameHostImpl* rfh = static_cast<RenderFrameHostImpl*>( 934 RenderFrameHostImpl* rfh = static_cast<RenderFrameHostImpl*>(
932 web_contents()->GetFocusedFrame()); 935 web_contents()->GetFocusedFrame());
933 if (rfh) 936 if (rfh)
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1069 range, character_bounds); 1072 range, character_bounds);
1070 } 1073 }
1071 #endif 1074 #endif
1072 1075
1073 void BrowserPluginGuest::SetContextMenuPosition(const gfx::Point& position) { 1076 void BrowserPluginGuest::SetContextMenuPosition(const gfx::Point& position) {
1074 if (delegate_) 1077 if (delegate_)
1075 delegate_->SetContextMenuPosition(position); 1078 delegate_->SetContextMenuPosition(position);
1076 } 1079 }
1077 1080
1078 } // namespace content 1081 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/common/browser_plugin/browser_plugin_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698