Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 2887973002: Fix an IME regression for <webview> due to missing IPC message param (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A BrowserPluginGuest is the browser side of a browser <--> embedder 5 // A BrowserPluginGuest is the browser side of a browser <--> embedder
6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder 6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder
7 // renderer side of browser <--> embedder renderer communication. 7 // renderer side of browser <--> embedder renderer communication.
8 // 8 //
9 // BrowserPluginGuest lives on the UI thread of the browser process. Any 9 // BrowserPluginGuest lives on the UI thread of the browser process. Any
10 // messages about the guest render process that the embedder might be interested 10 // messages about the guest render process that the embedder might be interested
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 void OnTextInputStateChanged(const TextInputState& params); 336 void OnTextInputStateChanged(const TextInputState& params);
337 void OnImeSetComposition( 337 void OnImeSetComposition(
338 int instance_id, 338 int instance_id,
339 const BrowserPluginHostMsg_SetComposition_Params& params); 339 const BrowserPluginHostMsg_SetComposition_Params& params);
340 void OnImeCommitText( 340 void OnImeCommitText(
341 int instance_id, 341 int instance_id,
342 const base::string16& text, 342 const base::string16& text,
343 const std::vector<blink::WebCompositionUnderline>& underlines, 343 const std::vector<blink::WebCompositionUnderline>& underlines,
344 const gfx::Range& replacement_range, 344 const gfx::Range& replacement_range,
345 int relative_cursor_pos); 345 int relative_cursor_pos);
346 void OnImeFinishComposingText(bool keep_selection); 346 void OnImeFinishComposingText(int instance_id, bool keep_selection);
347 void OnExtendSelectionAndDelete(int instance_id, int before, int after); 347 void OnExtendSelectionAndDelete(int instance_id, int before, int after);
348 void OnImeCancelComposition(); 348 void OnImeCancelComposition();
349 #if defined(OS_MACOSX) || defined(USE_AURA) 349 #if defined(OS_MACOSX) || defined(USE_AURA)
350 void OnImeCompositionRangeChanged( 350 void OnImeCompositionRangeChanged(
351 const gfx::Range& range, 351 const gfx::Range& range,
352 const std::vector<gfx::Rect>& character_bounds); 352 const std::vector<gfx::Rect>& character_bounds);
353 #endif 353 #endif
354 354
355 // Message handlers for messages from guest. 355 // Message handlers for messages from guest.
356 void OnHandleInputEventAck( 356 void OnHandleInputEventAck(
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 // Weak pointer used to ask GeolocationPermissionContext about geolocation 456 // Weak pointer used to ask GeolocationPermissionContext about geolocation
457 // permission. 457 // permission.
458 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_; 458 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;
459 459
460 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest); 460 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
461 }; 461 };
462 462
463 } // namespace content 463 } // namespace content
464 464
465 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_ 465 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698