Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: content/common/browser_plugin/browser_plugin_messages.h

Issue 2887973002: Fix an IME regression for <webview> due to missing IPC message param (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included message header, no traditional include guard. 5 // Multiply-included message header, no traditional include guard.
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/process/process.h" 9 #include "base/process/process.h"
10 #include "cc/surfaces/surface.h" 10 #include "cc/surfaces/surface.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 IPC_STRUCT_MEMBER(int, selection_start) 51 IPC_STRUCT_MEMBER(int, selection_start)
52 IPC_STRUCT_MEMBER(int, selection_end) 52 IPC_STRUCT_MEMBER(int, selection_end)
53 IPC_STRUCT_END() 53 IPC_STRUCT_END()
54 54
55 // Browser plugin messages 55 // Browser plugin messages
56 56
57 // ----------------------------------------------------------------------------- 57 // -----------------------------------------------------------------------------
58 // These messages are from the embedder to the browser process. 58 // These messages are from the embedder to the browser process.
59 // Most messages from the embedder to the browser process are CONTROL because 59 // Most messages from the embedder to the browser process are CONTROL because
60 // they are routed to the appropriate BrowserPluginGuest based on the 60 // they are routed to the appropriate BrowserPluginGuest based on the
61 // browser_plugin_instance_id which is unique per embedder process. 61 // |browser_plugin_instance_id| which is unique per embedder process.
62 // |browser_plugin_instance_id| is only used by BrowserPluginMessageFilter to
63 // find the right BrowserPluginGuest. It should not be needed by the final IPC
64 // handler.
62 65
63 // This message is sent from BrowserPlugin to BrowserPluginGuest to issue an 66 // This message is sent from BrowserPlugin to BrowserPluginGuest to issue an
64 // edit command. 67 // edit command.
65 IPC_MESSAGE_CONTROL2(BrowserPluginHostMsg_ExecuteEditCommand, 68 IPC_MESSAGE_CONTROL2(BrowserPluginHostMsg_ExecuteEditCommand,
66 int /* browser_plugin_instance_id */, 69 int /* browser_plugin_instance_id */,
67 std::string /* command */) 70 std::string /* command */)
68 71
69 // This message must be sent just before sending a key event. 72 // This message must be sent just before sending a key event.
70 IPC_MESSAGE_CONTROL2(BrowserPluginHostMsg_SetEditCommandsForNextKeyEvent, 73 IPC_MESSAGE_CONTROL2(BrowserPluginHostMsg_SetEditCommandsForNextKeyEvent,
71 int /* browser_plugin_instance_id */, 74 int /* browser_plugin_instance_id */,
(...skipping 10 matching lines...) Expand all
82 IPC_MESSAGE_CONTROL5( 85 IPC_MESSAGE_CONTROL5(
83 BrowserPluginHostMsg_ImeCommitText, 86 BrowserPluginHostMsg_ImeCommitText,
84 int /* browser_plugin_instance_id */, 87 int /* browser_plugin_instance_id */,
85 base::string16 /* text */, 88 base::string16 /* text */,
86 std::vector<blink::WebCompositionUnderline> /* underlines */, 89 std::vector<blink::WebCompositionUnderline> /* underlines */,
87 gfx::Range /* replacement_range */, 90 gfx::Range /* replacement_range */,
88 int /* relative_cursor_pos */) 91 int /* relative_cursor_pos */)
89 92
90 // This message is sent from BrowserPlugin to BrowserPluginGuest to notify that 93 // This message is sent from BrowserPlugin to BrowserPluginGuest to notify that
91 // inserting the current composition is requested. 94 // inserting the current composition is requested.
92 IPC_MESSAGE_CONTROL1(BrowserPluginHostMsg_ImeFinishComposingText, 95 IPC_MESSAGE_CONTROL2(BrowserPluginHostMsg_ImeFinishComposingText,
96 int /* browser_plugin_instance_id */,
93 bool /* keep selection */) 97 bool /* keep selection */)
94 98
95 // Deletes the current selection plus the specified number of characters before 99 // Deletes the current selection plus the specified number of characters before
96 // and after the selection or caret. 100 // and after the selection or caret.
97 IPC_MESSAGE_CONTROL3(BrowserPluginHostMsg_ExtendSelectionAndDelete, 101 IPC_MESSAGE_CONTROL3(BrowserPluginHostMsg_ExtendSelectionAndDelete,
98 int /* browser_plugin_instance_id */, 102 int /* browser_plugin_instance_id */,
99 int /* before */, 103 int /* before */,
100 int /* after */) 104 int /* after */)
101 105
102 // This message is sent to the browser process to indicate that the 106 // This message is sent to the browser process to indicate that the
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 201
198 // Forwards a PointerLock Unlock request to the BrowserPlugin. 202 // Forwards a PointerLock Unlock request to the BrowserPlugin.
199 IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetMouseLock, 203 IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetMouseLock,
200 int /* browser_plugin_instance_id */, 204 int /* browser_plugin_instance_id */,
201 bool /* enable */) 205 bool /* enable */)
202 206
203 // Sends text to be displayed in tooltip. 207 // Sends text to be displayed in tooltip.
204 IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetTooltipText, 208 IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetTooltipText,
205 int /* browser_plugin_instance_id */, 209 int /* browser_plugin_instance_id */,
206 base::string16 /* tooltip_text */) 210 base::string16 /* tooltip_text */)
OLDNEW
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698