Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon. (Closed)
Patch Set: dropped the datagrid check Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
index fd8bdcb6ed220b6fe5d945b445dc7a9b8fa6beca..ceafc8ef9d6a2501b7228f5c008ace944502b752 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
@@ -3,10 +3,9 @@
// found in the LICENSE file.
Network.NetworkWaterfallColumn = class extends UI.VBox {
/**
- * @param {number} rowHeight
* @param {!Network.NetworkTimeCalculator} calculator
*/
- constructor(rowHeight, calculator) {
+ constructor(calculator) {
// TODO(allada) Make this a shadowDOM when the NetworkWaterfallColumn gets moved into NetworkLogViewColumns.
super(false);
this.registerRequiredCSS('network/networkWaterfallColumn.css');
@@ -24,10 +23,14 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
this._rightPadding = 0;
this._scrollTop = 0;
- this._rowHeight = rowHeight;
this._headerHeight = 0;
this._calculator = calculator;
+ // this._rawRowHeight captures model height (41 or 21px),
+ // this._rowHeight is computed height of the row in CSS pixels, can be 20.8 for zoomed-in content.
+ this._rawRowHeight = 0;
+ this._rowHeight = 0;
+
this._offsetWidth = 0;
this._offsetHeight = 0;
this._startTime = this._calculator.minimumBoundary();
@@ -248,7 +251,12 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
* @param {number} height
*/
setRowHeight(height) {
- this._rowHeight = height;
+ this._rawRowHeight = height;
+ this._updateRowHeight();
+ }
+
+ _updateRowHeight() {
+ this._rowHeight = Math.floor(this._rawRowHeight * window.devicePixelRatio) / window.devicePixelRatio;
}
/**
@@ -330,6 +338,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
*/
onResize() {
super.onResize();
+ this._updateRowHeight();
this._calculateCanvasSize();
this.scheduleDraw();
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698