Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2887663002: Revert of Include headless tests in all swarm version for Windows, since it's been enabled (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, dvallet, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include headless tests in all swarm version for Windows, since it's been enabled (patchset #2 id:20001 of https://codereview.chromium.org/2841443002/ ) Reason for revert: This CL broke some Mac tests https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/40547 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/40547 FindIt report: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/40547 Original issue's description: > Include headless tests in all swarm version for Windows, since it's been enabled > Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002) > > BUG=686608 > > Review-Url: https://codereview.chromium.org/2841443002 > Cr-Commit-Position: refs/heads/master@{#472023} > Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3e41be71c3d2c TBR=dpranke@chromium.org,skyostil@chromium.org,dvallet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686608 Review-Url: https://codereview.chromium.org/2887663002 Cr-Commit-Position: refs/heads/master@{#472041} Committed: https://chromium.googlesource.com/chromium/src/+/c3ca8ada25a73ed77a68a85e09d990c2b99323bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -154 lines) Patch
M testing/buildbot/chromium.mac.json View 3 chunks +0 lines, -66 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +0 lines, -88 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kolos1
Created Revert of Include headless tests in all swarm version for Windows, since it's been ...
3 years, 7 months ago (2017-05-16 08:22:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887663002/1
3 years, 7 months ago (2017-05-16 08:23:08 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 08:23:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3ca8ada25a73ed77a68a85e09d9...

Powered by Google App Engine
This is Rietveld 408576698