Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2887653002: [json] Specialize parsed arrays to most specific kind (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[json] Specialize parsed arrays to most specific elements kind Depending on the input elements, we can allocate a FAST_{SMI_,DOUBLE_,}KIND backing store. BUG=v8:6398 Review-Url: https://codereview.chromium.org/2887653002 Cr-Commit-Position: refs/heads/master@{#45323} Committed: https://chromium.googlesource.com/v8/v8/+/63984db0600d381f0043e008b2b2f71c6d6cc187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -6 lines) Patch
M src/json-parser.cc View 2 chunks +69 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jgruber
3 years, 7 months ago (2017-05-16 08:38:45 UTC) #5
Benedikt Meurer
Nice. LGTM
3 years, 7 months ago (2017-05-16 08:40:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887653002/1
3 years, 7 months ago (2017-05-16 08:51:42 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 08:53:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/63984db0600d381f0043e008b2b2f71c6d6...

Powered by Google App Engine
This is Rietveld 408576698