[json] Specialize parsed arrays to most specific kind

src/json-parser.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/json-parser.h"
 
 #include "src/char-predicates-inl.h"
 #include "src/conversions.h"
 #include "src/debug/debug.h"
 #include "src/factory.h"
@@ skipping 470 matching lines @@
   DisallowHeapAllocation no_gc;
   DescriptorArray* descriptors = json_object->map()->instance_descriptors();
   int length = properties->length();
   for (int i = 0; i < length; i++) {
     Handle<Object> value = (*properties)[i];
     // Initializing store.
     json_object->WriteToField(i, descriptors->GetDetails(i), *value);
   }
 }
 
+class ElementKindLattice {
+ private:
+  enum {
+    SMI_ELEMENTS,
+    NUMBER_ELEMENTS,
+    OBJECT_ELEMENTS,
+  };
+
+ public:
+  ElementKindLattice() : value_(SMI_ELEMENTS) {}
+
+  void Update(Handle<Object> o) {
+    if (o->IsSmi()) {
+      return;
+    } else if (o->IsHeapNumber()) {
+      if (value_ < NUMBER_ELEMENTS) value_ = NUMBER_ELEMENTS;
+    } else {
+      DCHECK(!o->IsNumber());
+      value_ = OBJECT_ELEMENTS;
+    }
+  }
+
+  ElementsKind GetElementsKind() const {
+    switch (value_) {
+      case SMI_ELEMENTS:
+        return FAST_SMI_ELEMENTS;
+      case NUMBER_ELEMENTS:
+        return FAST_DOUBLE_ELEMENTS;
+      case OBJECT_ELEMENTS:
+        return FAST_ELEMENTS;
+      default:
+        UNREACHABLE();
+        return FAST_ELEMENTS;
+    }
+  }
+
+ private:
+  int value_;
+};
+
 // Parse a JSON array. Position must be right at '['.
 template <bool seq_one_byte>
 Handle<Object> JsonParser<seq_one_byte>::ParseJsonArray() {
   HandleScope scope(isolate());
   ZoneList<Handle<Object> > elements(4, zone());
   DCHECK_EQ(c0_, '[');
 
+  ElementKindLattice lattice;
+
   AdvanceSkipWhitespace();
   if (c0_ != ']') {
     do {
       Handle<Object> element = ParseJsonValue();
       if (element.is_null()) return ReportUnexpectedCharacter();
       elements.Add(element, zone());
+      lattice.Update(element);
     } while (MatchSkipWhiteSpace(','));
     if (c0_ != ']') {
       return ReportUnexpectedCharacter();
     }
   }
   AdvanceSkipWhitespace();
+
   // Allocate a fixed array with all the elements.
-  Handle<FixedArray> fast_elements =
-      factory()->NewFixedArray(elements.length(), pretenure_);
-  for (int i = 0, n = elements.length(); i < n; i++) {
-    fast_elements->set(i, *elements[i]);
+
+  Handle<Object> json_array;
+  const ElementsKind kind = lattice.GetElementsKind();
+
+  switch (kind) {
+    case FAST_ELEMENTS:
+    case FAST_SMI_ELEMENTS: {
+      Handle<FixedArray> elems =
+          factory()->NewFixedArray(elements.length(), pretenure_);
+      for (int i = 0; i < elements.length(); i++) elems->set(i, *elements[i]);
+      json_array = factory()->NewJSArrayWithElements(elems, kind, pretenure_);
+      break;
+    }
+    case FAST_DOUBLE_ELEMENTS: {
+      Handle<FixedDoubleArray> elems = Handle<FixedDoubleArray>::cast(
+          factory()->NewFixedDoubleArray(elements.length(), pretenure_));
+      for (int i = 0; i < elements.length(); i++) {
+        elems->set(i, elements[i]->Number());
+      }
+      json_array = factory()->NewJSArrayWithElements(elems, kind, pretenure_);
+      break;
+    }
+    default:
+      UNREACHABLE();
   }
-  Handle<Object> json_array = factory()->NewJSArrayWithElements(
-      fast_elements, FAST_ELEMENTS, pretenure_);
+
   return scope.CloseAndEscape(json_array);
 }
 
 template <bool seq_one_byte>
 Handle<Object> JsonParser<seq_one_byte>::ParseJsonNumber() {
   bool negative = false;
   int beg_pos = position_;
   if (c0_ == '-') {
     Advance();
     negative = true;
@@ skipping 289 matching lines @@
   AdvanceSkipWhitespace();
   return result;
 }
 
 // Explicit instantiation.
 template class JsonParser<true>;
 template class JsonParser<false>;
 
 }  // namespace internal
 }  // namespace v8