DevTools: Attempt to get badges from StackTrace in console

DevTools: Attempt to get badges from StackTrace in console

BUG=721538
Review-Url: https://codereview.chromium.org/2887603002
Cr-Commit-Position: refs/heads/master@{#472360}
Committed: https://chromium.googlesource.com/chromium/src/+/1b251fc2b0c7d5f2661188e5c3913642ae472b7b

[einbinder, 2017-05-16 00:46:34]

einbinder@chromium.org changed reviewers:
+ pfeldman@chromium.org

[einbinder, 2017-05-16 00:46:34]

ptal

[einbinder, 2017-05-16 02:18:15]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 02:18:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:23:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[einbinder, 2017-05-16 07:09:46]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:10:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 08:11:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 08:11:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2017-05-16 20:30:06]

https://codereview.chromium.org/2887603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2887603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:318:
for (var callFrame of this._message.stackTrace.callFrames) {
What about async chain frames? You could go all the way blaming...

https://codereview.chromium.org/2887603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:320:
return this._badgePool.badgeForURL(new Common.ParsedURL(callFrame.url));
Do you want the first mapped url or any first url badge?

[einbinder, 2017-05-16 20:41:35]

https://codereview.chromium.org/2887603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2887603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:318:
for (var callFrame of this._message.stackTrace.callFrames) {
On 2017/05/16 at 20:30:06, pfeldman wrote:
> What about async chain frames? You could go all the way blaming...

Done.

https://codereview.chromium.org/2887603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:320:
return this._badgePool.badgeForURL(new Common.ParsedURL(callFrame.url));
On 2017/05/16 at 20:30:06, pfeldman wrote:
> Do you want the first mapped url or any first url badge?

I think I want the first URL for now. I want to try to stay close to what the
user sees for the linked url, unless that url is VM###.

[pfeldman, 2017-05-16 20:43:49]

https://codereview.chromium.org/2887603002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt
(right):

https://codereview.chromium.org/2887603002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt:8:
console-log-linkify-links.html:6 http://www.chromium.org/ console-message >
source-code > console-message-anchor > devtools-link > console-message-badge >
product-registry-badge monospace hidden > console-message-text > devtools-link
This might be a race

[einbinder, 2017-05-16 21:06:01]

https://codereview.chromium.org/2887603002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt
(right):

https://codereview.chromium.org/2887603002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt:8:
console-log-linkify-links.html:6 http://www.chromium.org/ console-message >
source-code > console-message-anchor > devtools-link > console-message-badge >
product-registry-badge monospace hidden > console-message-text > devtools-link
On 2017/05/16 at 20:43:49, pfeldman wrote:
> This might be a race

This gets added synchronously. The hidden class will stay on it as long as
badges are off by default. If they are on by default we will have a race.

[pfeldman, 2017-05-16 21:35:26]

lgtm

[einbinder, 2017-05-16 21:47:51]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-05-16 21:49:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:18:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[einbinder, 2017-05-17 02:03:09]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-05-17 02:05:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:54:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494986589086190,
"parent_rev": "39ebcbc314998f76d3fd56cdf633ab29ef809d4c", "commit_rev":
"1b251fc2b0c7d5f2661188e5c3913642ae472b7b"}

[commit-bot: I haz the power, 2017-05-17 06:54:52]

Description was changed from

==========
DevTools: Attempt to get badges from StackTrace in console

BUG=721538
==========

to

==========
DevTools: Attempt to get badges from StackTrace in console

BUG=721538

Review-Url: https://codereview.chromium.org/2887603002
Cr-Commit-Position: refs/heads/master@{#472360}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b251fc2b0c7d5f2661188e5c391...
==========

[commit-bot: I haz the power, 2017-05-17 06:54:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1b251fc2b0c7d5f2661188e5c391...