Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2887603002: DevTools: Attempt to get badges from StackTrace in console (Closed)
Patch Set: async checking Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 1359d4fcd127582c0076cd5e99708ba1551961f9..e1e45a8719ab74cad140ff119d1a9c3c5e46e55b 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -301,6 +301,29 @@ Console.ConsoleViewMessage = class {
* @return {?Element}
*/
_buildMessageBadge() {
+ var badgeElement = this._badgeElement();
+ if (!badgeElement)
+ return null;
+ badgeElement.classList.add('console-message-badge');
+ return badgeElement;
+ }
+
+ /**
+ * @return {?Element}
+ */
+ _badgeElement() {
+ if (this._message._url)
+ return this._badgePool.badgeForURL(new Common.ParsedURL(this._message._url));
+ if (this._message.stackTrace) {
+ var stackTrace = this._message.stackTrace;
+ while (stackTrace) {
+ for (var callFrame of this._message.stackTrace.callFrames) {
+ if (callFrame.url)
+ return this._badgePool.badgeForURL(new Common.ParsedURL(callFrame.url));
+ }
+ stackTrace = stackTrace.parent;
+ }
+ }
if (!this._message.executionContextId)
return null;
var runtimeModel = this._message.runtimeModel();
@@ -315,9 +338,7 @@ Console.ConsoleViewMessage = class {
var frame = resourceTreeModel.frameForId(executionContext.frameId);
if (!frame || !frame.parentFrame)
return null;
- var badgeElement = this._badgePool.badgeForFrame(frame);
- badgeElement.classList.add('console-message-badge');
- return badgeElement;
+ return this._badgePool.badgeForFrame(frame);
}
/**

Powered by Google App Engine
This is Rietveld 408576698