Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2887433003: Use CorrespondingUseElement() in SVGElement::TreeScopeForIdResolution (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Use CorrespondingUseElement() in SVGElement::TreeScopeForIdResolution For elements sourced non-locally, CorrespondingElement() will give the TreeScope of the document it was sourced from rather than the TreeScope of the <use> element. Until we are able to resolve references at ComputedStyle resolution, attempt to use the host of the shadow tree, i.e the (outermost) <use> element. (This will not work when external paint servers are supported, or with a paint server defined in the referenced document.) BUG=721167 Review-Url: https://codereview.chromium.org/2877973002 Cr-Original-Commit-Position: refs/heads/master@{#471955} Review-Url: https://codereview.chromium.org/2887433003 . Cr-Commit-Position: refs/branch-heads/3071@{#576} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1d80901cae8f06131cce44f0719d93cd580bd3df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/svg/custom/resources/rect100x100.svg View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/use-external-local-fill.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/use-external-local-fill-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
fs
3 years, 7 months ago (2017-05-16 06:30:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d80901cae8f06131cce44f0719d93cd580bd3df.

Powered by Google App Engine
This is Rietveld 408576698