Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2877973002: Use CorrespondingUseElement() in SVGElement::TreeScopeForIdResolution (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use CorrespondingUseElement() in SVGElement::TreeScopeForIdResolution For elements sourced non-locally, CorrespondingElement() will give the TreeScope of the document it was sourced from rather than the TreeScope of the <use> element. Until we are able to resolve references at ComputedStyle resolution, attempt to use the host of the shadow tree, i.e the (outermost) <use> element. (This will not work when external paint servers are supported, or with a paint server defined in the referenced document.) BUG=721167 Review-Url: https://codereview.chromium.org/2877973002 Cr-Commit-Position: refs/heads/master@{#471955} Committed: https://chromium.googlesource.com/chromium/src/+/6d8df7c57b4cc1beb9816b7379d88a48650dd507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/svg/custom/resources/rect100x100.svg View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/use-external-local-fill.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/use-external-local-fill-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
fs
3 years, 7 months ago (2017-05-12 14:56:05 UTC) #6
pdr.
On 2017/05/12 at 14:56:05, fs wrote: > LGTM
3 years, 7 months ago (2017-05-15 20:18:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877973002/1
3 years, 7 months ago (2017-05-15 20:33:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/427137)
3 years, 7 months ago (2017-05-15 23:14:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877973002/1
3 years, 7 months ago (2017-05-15 23:22:32 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 00:22:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d8df7c57b4cc1beb9816b7379d8...

Powered by Google App Engine
This is Rietveld 408576698